458252 - local file paths are wrong on windows mobile

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1 - patch from blassey

nslocalfile assumes that we have drive letters on windows mobile.  this isn't the case.

Comment 1

[Benjamin Smedberg]

Comment on attachment 341479 [details] [diff] [review]
patch v.1 - patch from blassey

A little more context would be helpful.

>diff -r 2450609542ba netwerk/base/src/nsURLHelperWin.cpp

>+#ifdef WINCE
>+    NS_NAMED_LITERAL_CSTRING(prefix, "file://");
>+#else
>     NS_NAMED_LITERAL_CSTRING(prefix, "file:///");

This deserves a comment at least: the final URL has triple-slashes, it's just that the last URL is taken from the actual path.

>diff -r 2450609542ba xpcom/io/nsLocalFileWin.cpp

>-    if ( ( (secondChar == L':') && !FindCharInReadable(L'/', begin, end) ) ||  // normal path
>+    if ( ( 
>+#ifndef WINCE
>+         (secondChar == L':') && 
>+#endif
>+         !FindCharInReadable(L'/', begin, end) ) ||  // normal path
> #ifdef WINCE
>          ( (firstChar == L'\\') )   // wince absolute path or network path
> #else

Can you please coalesce the two WINCE hunks? The "firstChar == L'\\' is the WINCE equivalent of the secondChar == L':' hunk

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

taking bug so I remember to update the patch

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: updated based on bsmedberg's comments

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

6a0475a370b1: Bug 458252: local file paths are wrong on windows mobile r=dougt sr=bsmedberg
diff
browse
Brad Lassey <[e-mail]> - Mon, 20 Oct 2008 13:03:20 -0400 - rev 20674
Bug 458252: local file paths are wrong on windows mobile r=dougt sr=bsmedberg