45845 - Cannot build with --disable-detect-webshell-leaks (nsWebShell.cpp:1433)

Status: VERIFIED WORKSFORME

(SeaMonkey :: Build Config, defect, P3)

Description

[Decklin Foster]

If I ./configure with the --disable-detect-webshell-leaks (or simply omit it, as
disabled is the default) I can no longer build (as of 5AM PDT 07/19). I get the
following error:

nsWebShell.cpp: At top level:
nsWebShell.cpp:1433: `long unsigned int
nsWebShell::gNumberOfWebShells' is not a static member of `class nsWebShell'
make[2]: *** [nsWebShell.o] Error 1

the offending line is here:
http://lxr.mozilla.org/seamonkey/source/docshell/base/nsWebShell.cpp#1433

As you can see, it's bracketed off by #ifdef DETECT_WEBSHELL_LEAKS, which gets
defined even if we have disabled it. Therefore I am guessing that the error is
in the configure script.

Comment 1

[cls]

Hmm. We appear to unconditionally define DETECT_WEBSHELL_LEAKS.  It appears that
change was made a while ago.  At any rate, I can't reproduce the bustage. 
jdunn's fix for aix may have fixed this.  Marking worksforme.

Comment 2

[Decklin Foster]

Verifying that this has been fixed since the 19th. Thanks.