458589 - Drag and drop ical (.ics) attachments onto calendar icon does nothing

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Przemyslaw Bialik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20081004 Lightning/1.0pre Shredder/3.0b1pre ID:20081004031302

Drag and drop ical (.ics) attachments onto calendar / tasks icon does nothing.

Reproducible: Always

Steps to Reproduce:
1. Drag and drop ical (.ics) attachment onto calendar / tasks icon.
Actual Results:  
Nothing happens.

Expected Results:  
New event / task creation.

Error: [Exception... "Could not convert JavaScript argument arg 0 [nsIUnicharStreamLoader.init]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: chrome://calendar/content/calendar-dnd-listener.js :: calDNDDrop :: line 324"  data: no]
Source File: chrome://calendar/content/calendar-dnd-listener.js
Line: 326

Comment 1

[Daniel Boelzle [:dbo]]

Works for me on Mac.

Comment 2

[Andreas Treumann]

I checked this issue on Linux and Windows and I get the exception too.

Comment 3

[Stefan Sitter [:ssitter]]

Confirmed using Lightning 1.0pre (ID: 20081007031722) and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20081007 Shredder/3.0b1pre (ID: 20081007031514).

Comment 4

[Martin Schröder [:mschroeder]]

Could this be related to the landing of the new Drag&Drop API (http://developer.mozilla.org/en/DragDrop/Drag_and_Drop)?

Comment 5

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

I can reproduce it now.

It seems to be an incompatible change on trunk.

Comment 6

[Daniel Boelzle [:dbo]]

Attachment: fix - v2

- fixing missing calendar for item, too

Comment 7

[Martin Schröder [:mschroeder]]

Comment on attachment 342230 [details] [diff] [review]
fix - v2

r=mschroeder

Comment 8

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a0784e1ef1fc>

-> FIXED

Comment 9

[Przemyslaw Bialik]

> -> FIXED
I've tried to verify on manually patched latest build but since a few builds drag and drop to calendar / tasks new icons is not allowed and this patch didn't changed it so it's a little hard to verify ;) -> reopening or new bug ?

Comment 10

[Daniel Boelzle [:dbo]]

Christian has set up bug 459641.

Comment 11

[Przemyslaw Bialik]

Thanks.
I've applied the patch to the latest build with the "classic" calendar toolbar (build 20081008091054) and I still can't verify the fix ?
(bug 459641 would unlock drop action but if this bug is not really fixed then not much would change)

Error: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIChannel.asyncOpen]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://calendar/content/calendar-dnd-listener.js :: calDNDDrop :: line 325"  data: no]
Source File: chrome://calendar/content/calendar-dnd-listener.js
Line: 328

Comment 12

[Daniel Boelzle [:dbo]]

The fix has worked for me on Mac at that time, dragging an iTIP attachment onto the mode buttons. Maybe you're dragging something else? Please give some more details, especially your platform.

Comment 13

[Daniel Boelzle [:dbo]]

I keep this bug open and recheck the fix once bug 459641 is fixed.

Comment 14

[Przemyslaw Bialik]

I don't know what kind of problems you had with confirming this bug at the beginning but regarding my comment 11 it was - let's say broken e-mail...

-> Verifying as fixed (if it would be broken after bug 459641 is fixed then it would be a different bug)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081014 Lightning (patched build 20081007031722)/1.0pre Shredder/3.0b1pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081014 Lightning (patched build 20081007032648)/1.0pre Shredder/3.0b1pre

Comment 15

[Przemyslaw Bialik]

For those interested:
I will not be filing bug against lightning regarding comment 11 error (invite.ics attachment was detached and removed from the file system) because I should be thankful Bug 292385

> Maybe you're dragging something else?
yeah, attachment that isn't there and so NS_ERROR_FILE_NOT_FOUND ;)