45859 - remove Mozilla Preferences shortcut

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[sairuh (rarely reading bugmail)]

in bug 40698, the -pref option was removed for winnt and linux. this bug is the
for the Mac "equivalent": we might as well be consistent and remove the Mozilla
Preferences shortcut/icon. after all, double-clicking it doesn't even bring up
the Preferences dialog (merely starts up the browser).

Comment 1

[J.J. Enser]

Don et al,
This can be changed to "build/config" component
feel free to reassign this to me if this gets approved. (I don't see any beta2 or 
dogfood keyword for the moment)

Comment 2

[sairuh (rarely reading bugmail)]

nominating for beta2 (no biggie, tho').

Comment 3

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 4

[don]

Chris, let's fix this before we go out the door.  I don't think it's needed for 
beta 3.  See my comments in bug #40698.

Comment 5

[sairuh (rarely reading bugmail)]

if bug 46105 is fixed before this one, pls invalidate this bug.

Comment 6

[Daniel Veditz [:dveditz]]

Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.

Comment 7

[Chris McAfee]

over to pchen.

Comment 8

[J.J. Enser]

Paul, let's try and coordinate this in the next 2 days if possible because I'll 
be on vacation after that and this change has implication on the release build 
packaging process.

Comment 9

[don]

Paul, see if you can come up with a patch for this ...

Comment 10

[Paul Chen]

Attachment: remove perl code to make preferences document

Comment 11

[Paul Chen]

just got r=pinkerton

Comment 12

[Simon Fraser [no longer active]]

Dup of 56144, unless you want to actually remove the file from teh build. Either 
way, if 56144 is fixed, this bug is irrelevant to RTM.

Comment 13

[J.J. Enser]

#56144 is now fixed, and no "pref" shortcut will appear with commercial rtm 
installer.
this bug remains valid for mozilla builds and trunk commercial.

Also, keep in mind that adding or removing files from the build script, resulting 
in a change in what gets exported to mozilla:dist:viewer, often has repercutions 
on the installer and should be reflected in mozilla/xpinstall/packages-mac
(that's where I just removed the extra shortcuts, including Mozilla Preferences, 
see #56144)

note: if the proposed patch is still pertinent, it could be enhanced to remove 
other potentially obsolete shortcuts.

Comment 14

[don]

True, but I wouldn't stop ship to remove those shortcuts.  Minus.

Comment 15

[Marcia Knous [:marcia]]

Netscape Nav Triage Team: If patch already available, please review and check 
in. This is not a Netscape beta stopper.

Comment 16

[J.J. Enser]

We need an update on this:
- list of shortcuts to be included in Mozilla developer builds
- list of shortcuts to be included in Mozilla Release builds (subset of the 
above)
- list of shortcuts to be included in Netscape developers builds
- list of shortcuts to be included in Netscape Release builds

this will help figuring out what needs to be changed between the perl script 
(Mozilla/NetscapeBuildList.pm), the installer manifest files (Mozilla/Netscape 
packages-mac), and the release packaging script (BuildCentral)

Comment 17

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar

Comment 18

[J.J. Enser]

Mozilla shortcuts/prefs launchers have been removed from mozilla _installer_ 
(they still get built into dist).
This issue is largely discussed in bug 74590 as well as http://
bugscape.netscape.com/show_bug.cgi?id=4759 and http://bugscape.netscape.com/
show_bug.cgi?id=4977 

I think this one can be closed, but I'll let pchen decide.

Comment 19

[sairuh (rarely reading bugmail)]

adding direct link here: http://bugscape.netscape.com//show_bug.cgi?id=4977

so, i checked the help output and it looks like:

* [reconfirming] in 2001.06.11.08 comm linux bits, -pref is no longer in the
-help output.

* [reconfirming] from smfr's win32 mozilla [debug from 25 may 2001], -pref is no
longer in the -help output.

* [confirming] the Preferences icon is no longer in the Mac 2001.06.07.11-branch
or 2001.06.11.08-trunk comm bits [used blob installers for both].

gonna go check some mozilla and non-installer bits on mac...

Comment 20

[sairuh (rarely reading bugmail)]

more tests:

a. 2001.06.12.08-trunk mozilla installer blob: *still* contains Preferences icon
[not expected].

b. 2001.06.12.08-trunk mozilla non-installer: still contains Preferences icon
[expected per jj's comments].

c. 2001.06.12.08-trunk commercial non-installer: does *not* contain Preferences
icon.

d. 2001.06.07.11-branch commercial non-installer: does *not* contain Preferences
icon.

because of (a), i'd still keep this open.

interesting that (c) and (d) no longer have the Preferences icon, even tho' the
non-installer bits are used. unless
http://bugscape.netscape.com//show_bug.cgi?id=4977 took care of this anyhow, for
commercial builds.

so, readjusting summary so that this reflects the mozilla case.

Comment 21

[Asa Dotzler [:asa]]

->XP Apps default assignee

Comment 22

[Peter Trudelle]

->future

Comment 23

[J.J. Enser]

future ??? no way.
we have a trivial patch submitted since ... Oct.00 !!!

The proper way to eliminate unnecessary shortcut files from release builds is to
stop exporting them to dist, instead of having patches in the release automation
to undo what the build script has done 5 mn. earlier.

taking bug and marking 0.9.9

Comment 24

[J.J. Enser]

status update: The standard build script still generates a dozen shortcuts
(Cmd-line files) in dist/viewer, but only 2 of them get packaged into the
installer (Profile Manager and Profile Migration), which is actually what leaves
the buidling.

Se I'll mark this bug fixed since this is enough to correct the problem
initially  reported.
As to removing from the build script the code that exports to (polutes?) dist
with obsolete/unsused shortcuts, I've already asked people's general opinion in
the mozilla newsgroups, but didn't get relevant feedback to go one way or another.

Whenever someone has a strong feeling about removing this code, we'll reopen
this bug or log a new one.

Comment 25

[Simon Fraser [no longer active]]

Let's nuke all except the ones we ship, and see who squeals. Seriously.

Comment 26

[sairuh (rarely reading bugmail)]

*zap* no longer there in latest os x mozilla bits.