458651 - Clicking links with text-decoration: blink doesn't always work

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, when clicking on the link, it doesn't work when the text is invisible, only when the text is visible.
This regressed somewhere between Firefox 2 and Firefox 3.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060125 Firefox/1.6a1 ID:2006012505
fails:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060126 Firefox/1.6a1 ID:2006012609

=> range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-01-25+04%3A00&maxdate=2006-01-26+10%3A00&cvsroot=%2Fcvsroot

(this was painful finding since the 1.6a builds of those days crashed on https sites for me -> got to save the testcase locally ...)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Probably bug 317375

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: patch

I do not know why I am fixing this.

I couldn't find any spec saying anything about taking or not taking a click when the text is invisible. So I don't know if we want to do this or not.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 382253 [details] [diff] [review]
patch

Why not!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

If you can't find anything more interesting than this to do, we should talk :-)

Comment 6

[Timothy Nikkel (:tnikkel)]

(In reply to comment #5)
> If you can't find anything more interesting than this to do, we should talk :-)

I'll try to catch you online tomorrow, or ping me when it's a good time for you.

Comment 7

[Martijn Wargers (dead)]

(In reply to comment #5)
> If you can't find anything more interesting than this to do, we should talk :-)

All the bugs I file are very interesting!
Timothy, please, feel free to continue fixing them!

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/d7b4504ea75c