458919 - Expose .parameters on function declarations

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

Attachment: Expose .parameters on function declarations, rev. 1

Expose .parameters on function declarations, which allows me to map parameter names against their doxygen comments.

Comment 1

[(dormant account)]

Comment on attachment 342102 [details] [diff] [review]
Expose .parameters on function declarations, rev. 1


> 
>+      tree args;
>+
>+      if (TREE_CODE(v) == FUNCTION_DECL) {
>+        JSObject *arglist = JS_NewArrayObject (this->cx, 0, NULL);
>+        dehydra_defineProperty (this, obj, "parameters",
>+                                OBJECT_TO_JSVAL (arglist));
>+
>+        tree args; 
                  ^--- looks like a typo(nuke one above). Surprised GCC let that compile

>+        for (args = DECL_ARGUMENTS(v); args; args = TREE_CHAIN (args))
>+          dehydra_addVar(this, args, arglist);
>+      }
>+

Comment 2

[Benjamin Smedberg]

Pushed, http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/2b4111b62343