Closed
Bug 458983
Opened 16 years ago
Closed 16 years ago
dead stuff in nsHTMLElement
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(4 files)
4.90 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
52.80 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
44.22 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
2.44 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #342160 -
Flags: review?(mrbkap)
Updated•16 years ago
|
Attachment #342160 -
Flags: superreview+
Attachment #342160 -
Flags: review?(mrbkap)
Attachment #342160 -
Flags: review+
Assignee | ||
Comment 1•16 years ago
|
||
here is a more exciting patch! Missed this unused member last time as I was fixing some false positives in my detector and was rerunning the analysis, so didn't have most recent data.
Comment 2•16 years ago
|
||
Comment on attachment 342270 [details] [diff] [review] found an unused member I bow to your regexp-fu! :)
Attachment #342270 -
Flags: superreview+
Attachment #342270 -
Flags: review?(mrbkap)
Attachment #342270 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
sorry for patch bombing, caveman algorithm causes long turnarounds so i miss these things initially.
Attachment #342330 -
Flags: review?(mrbkap)
Comment 4•16 years ago
|
||
Comment on attachment 342330 [details] [diff] [review] another unused member that surfaces after analysing with patch 1 Keep patch bombing me. I'm glad to see this stuff go!
Attachment #342330 -
Flags: superreview+
Attachment #342330 -
Flags: review?(mrbkap)
Attachment #342330 -
Flags: review+
Assignee | ||
Comment 5•16 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/8ba4bc3e2d8b
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
confused, you left dead code afaict: http://mxr.mozilla.org/comm-central/search?string=ContainFunc * line 99 -- typedef PRBool (*ContainFunc)(eHTMLTags aTag,nsDTDContext &aContext); Found one matching line please do try to kill typedefs when you whack all consumers :)
Assignee | ||
Comment 7•16 years ago
|
||
timeless is right, I didn't get everything. I don't yet scan for dead typedefs(it's hardly worth the hassle afaik).
Attachment #342957 -
Flags: review?(mrbkap)
Assignee | ||
Updated•16 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•16 years ago
|
Attachment #342957 -
Flags: superreview+
Attachment #342957 -
Flags: review?(mrbkap)
Attachment #342957 -
Flags: review+
Assignee | ||
Comment 8•16 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/e0d2eba61212
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•