459218 - Wizard back and next / finish buttons have incorrect space between them

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Robert Strong (they/them - no direct email)]

See attached screenshots

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: screenshots

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 3

[Simon Bünzli]

Isn't that 1px too little between Back and Forward buttons?

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> Isn't that 1px too little between Back and Forward buttons?
I thought the same and just went with the exiting values. There are also other tweaks that should be done as can be seen when comparing it to the windows provided wizard and I would prefer them to be done in another bug.

Comment 5

[Robert Strong (they/them - no direct email)]

Filed Bug 459280 for the inconsistencies I've noticed while working with the wizard.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 342416 [details] [diff] [review]
patch

>diff --git a/toolkit/themes/winstripe/global/wizard.css b/toolkit/themes/winstripe/global/wizard.css
>--- a/toolkit/themes/winstripe/global/wizard.css
>+++ b/toolkit/themes/winstripe/global/wizard.css
>@@ -35,16 +35,16 @@ 
>...
>-.wizard-button[wizardbutton="finish"],
>-.wizard-button[wizardbutton="next"] {
>+.wizard-button[dlgtype="finish"],
>+.wizard-button[dlgtype="next"] {
>   -moz-margin-start: -1px !important;
> }
Dave, I went ahead a visually verified that this should be 0px to be consistent and I'll change that prior to checkin. The remainder of the issues that I've noticed will be handled in bug 459280

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 342416 [details] [diff] [review]
patch

Looks fine, sorry for not getting to it sooner

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central with the change mentioned in comment #6

http://hg.mozilla.org/mozilla-central/rev/beb27b78ba0b