45928 - NativeDate uses getDeclaredConstructor instead of getConstructor

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect, P3)

Description

[Brian D. Carlstrom]

We had to make the following change to NativeDate.java to get it to work in the 
browser in the applet sandbox. Note that there is no reason to call the version 
that even can access the private constructors, since it's a public constructor 
it's looking for. I believe that this affects both Netscape and IE.

use getConstructor() instead of getDeclaredConstructor(). This is because
reflective access to the native data formatter is restricted in the browser.

Comment 1

[Norris Boyd]

Mike, do you see any problems with making this change?

Comment 2

[Mike McCabe]

Why does getDeclaredConstructor fail and getConstructor succeed, when the
constructor in question is public?

Looks like the methods are equivalent in this case.  This change looks fine to
me.

Comment 3

[Norris Boyd]

Checking in org/mozilla/javascript/NativeDate.java;
/cvsroot/mozilla/js/rhino/org/mozilla/javascript/NativeDate.java,v  <--  NativeD
ate.java
new revision: 1.9; previous revision: 1.8
done

Comment 4

[Phil Schwartau]

Verifying -

Comment 5

[Brian D. Carlstrom]

Thanks a lot for fixing this. I agree that it is lame for getDeclaredConstuctor 
to fail if it is in fact asking for a public method, but all the getDeclared* 
work this way.