459280 - Several inconsistencies between the theme for wizards and OS provided wizards

Status: NEW

(Toolkit :: Themes, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: screenshots

a) spacing between the cancel button and the edge of the window is larger than OS provided wizards.
b) button height is larger than OS provided wizards.
c) the height of the box surrounding the buttons is larger than OS provided wizards.

See attachment for examples

There may be others

The width of the example Toolkit Wizard has width defined and is not a bug with the existing wizard though it has been a while since I checked the default width of the wizard.

Bug 459218 restores the broken spacing between the wizard's back and next / finish buttons though the pre-existing css may be incorrect.

Comment 1

[Robert Strong (they/them - no direct email)]

A quick investigation shows that...

Adding the following to wizard.css
+ .wizard-button > .button-box {
+   padding-top: 0px;
+   padding-bottom: 0px;
+ }

and removing the following (redundant?) from global.css

  button[disabled="true"] > .button-box {
-   padding-top: 1px !important;
-   padding-bottom: 2px !important;
    -moz-padding-start: 3px !important;
    -moz-padding-end: 4px !important;
  }

fixes b and c

a quick look at a couple of other buttons on Windows (Vista at least) shows that the toolkit default button height is larger that it should be by this same amount... so, it may be better to lessen the default button height (at least on Windows Vista) instead to fix b and c.

Comment 2

[Robert Strong (they/them - no direct email)]

note: when I state height in the previous comments I am referring to the overall height including margins, padding, etc. so lessening the height in the example above is accomplished by removing padding and not changing the element's height.

Comment 3

[Thomas Stache]

If OS consistency is key, it should be investigated how Toolkit can mimic the new "Aero style Wizards", that were introduced with Vista.
http://msdn.microsoft.com/en-us/library/aa511302.aspx

The "Add Hardware" example in the screenshot is a legacy wizard.

Comment 4

[Robert Strong (they/them - no direct email)]

I agree that it would be great to get Aero style wizard support but that in no way means that we shouldn't fix the inconsistencies with the current wizard. I believe there is already a bug for adding the Aero style wizard but if you can't find it please file a new bug.