Closed
Bug 459381
Opened 16 years ago
Closed 15 years ago
Calendar and task tabs should be persistent
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: andreas.treumann, Assigned: Fallen)
Details
(Whiteboard: [not needed beta][no l10n impact])
Attachments
(1 file)
3.08 KB,
patch
|
mschroeder
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: =================== - open the calendar and/or the task tab - restart thunderbird RESULT: ======= - only the mail tab is open EXPECTED RESULT: ================ - after restart also the calendar/task tab should visible REPRODUCIBLE: ============= - always
Reporter | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
Comment 2•15 years ago
|
||
Bug 459096 has been fixed by Bug 498106, but only for mail tabs. Session restore for calendar and task tab still doesn't work -> reopen.
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Updated•15 years ago
|
Status: REOPENED → NEW
Assignee | ||
Comment 3•15 years ago
|
||
We should fix this for 1.0. It would be nice to take this for the beta, but thats not a must.
Flags: blocking-calendar1.0+
Whiteboard: [not needed beta][no l10n impact]
Assignee | ||
Comment 4•15 years ago
|
||
This turns out to be much easier than I thought. Patch persists the calendar and task tab, additionally persisting the currently selected day for the calendar tab.
Assignee | ||
Updated•15 years ago
|
Attachment #393435 -
Flags: review? → review?(mschroeder)
Comment 5•15 years ago
|
||
Comment on attachment 393435 [details] [diff] [review] Fix - v1 r=mschroeder with following nits: >--- a/calendar/lightning/content/messenger-overlay-sidebar.js >+++ b/calendar/lightning/content/messenger-overlay-sidebar.js >@@ -68,6 +68,10 @@ > // foreground. > ltnSwitch2Calendar(); > } >+ >+ if (("selectedDay" in aArgs) && aArgs.selectedDay != null) { >+ currentView().goToDay(aArgs.selectedDay); >+ } > }, > showTab: function(aTab) { Add empty line before the function. >+ onTitleChanged: function(aTab) { >+ // Make sure the title is updated. >+ // TODO We should move this to a dedicated string some time. >+ aTab.title = document.getElementById("calendar-tab-button").getAttribute("tooltiptext"); >+ }, Has there already a bug been filed? I'm not sure. >+ supportsCommand: function (tab, command) calendarController.supportsCommand(command), >+ isCommandEnabled: function (tab, command) calendarController.isCommandEnabled(command), >+ doCommand: function(tab, command) calendarController.doCommand(command), >+ onEvent: function(tab, event) calendarController.onEvent(event) >+ > }, Remove empty line before end of block. >+ supportsCommand: function (tab, command) calendarController.supportsCommand(command), >+ isCommandEnabled: function (tab, command) calendarController.isCommandEnabled(command), >+ doCommand: function(tab, command) calendarController.doCommand(command), >+ onEvent: function(tab, event) calendarController.onEvent(event) Maybe it's better to adhere to the API using aTab, aCommand and aEvent as arguments. Also true for the calendar tab code above.
Attachment #393435 -
Flags: review?(mschroeder) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/07c4ff099a14> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Assignee | ||
Comment 7•15 years ago
|
||
(In reply to comment #5) > Has there already a bug been filed? I'm not sure. Filed bug 511518.
Assignee | ||
Comment 8•13 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•