459423 - Queued downloads can be given identical filenames, resulting in overwriting

Status: VERIFIED DUPLICATE of bug 301328

(Toolkit :: Downloads API, defect)

Description

[Jesse Ruderman]

Yesterday, I alt+clicked a bunch of links to various files named 001.mpg, and Firefox decided to save the last five all as 001(2).mpg before any of those five actually started downloading.  When they did start downloading, four of them got clobbered.

Mac, trunk, non-debug

Comment 1

[Justin Wood (:Callek)]

From my memory of the code, this is definately possible...

We probably should resolve conflicts as they are started (or stuff a placeholder file for pending DLs), rather than on first demand.

Comment 2

[Shawn Wilsher :sdwilsh]

I think the UI doesn't show the right filename, but I thought we didn't overwrite.  I could be wrong though...

Comment 3

[david.c.mann]

The files are correctly renamed on the filesystem, but the UI shows the "original" filename. When downloading multiple files of the same name (report.xls for example) you get multiple entries in the download manager for report.xls, and on disk, get report.xls, report-1.xls, report-2.xls etc. 

Unfortunately, clicking on any of the "report.xls" entries in the download manager just opens the first download, and it is impossible to open the others by clicking on the entries in the download manager.

Possible solution: instead of listing the files by the original name in the download manager, list them by the actual filename on disk...