Closed Bug 460029 Opened 16 years ago Closed 16 years ago

additional piece of nsRuleNode::ComputeDisplayData should have been removed

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

patch
2.27 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
While looking at bug 460012, I noticed that an additional piece of nsRuleNode::ComputeDisplayData should have been removed.  The chunk at the beginning that always ensures a real parentDisplay was there so that the chunk removed in bug 238072 had a correct parentDisplay.  It's harmless, but no longer needed.
Attached patch patch — — Splinter Review 

        Attachment #343234 -
        Flags: superreview?(bzbarsky)

        Attachment #343234 -
        Flags: review?(bzbarsky)

    
    

    
  
The code being removed was introduced in bug 171749 and refactored in bug 332333.

        Attachment #343234 -
        Flags: superreview?(bzbarsky)

        Attachment #343234 -
        Flags: superreview+

        Attachment #343234 -
        Flags: review?(bzbarsky)

        Attachment #343234 -
        Flags: review+

    
    

    
  
Fixed: http://hg.mozilla.org/mozilla-central/rev/30df17ed7d7f
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: