460293 - Implement Bugzilla::Object::set_all and have editkeywords.cgi use it

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P1)

Description

[Max Kanat-Alexander]

set_all would be a function where you pass in a hash and it calls all the set_ functions for the object, in the right order. The "right order" should probably be considered the order of UPDATE_COLUMNS, but that's hard because the column names and the setter names are different. It might be time to just fix that and name things better in the DB.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Wow, this was so easy I don't know why we didn't implement it earlier.

I didn't do any of the ordering stuff here. In the future, if we need the set_ functions to be called in a specific order, we can add a constant called SET_ORDER that orders just the ones that need to be in some order. (That should help us keep things straight with Bugzilla::Bug, too.)

Comment 2

[Frédéric Buclin]

Comment on attachment 343720 [details] [diff] [review]
v1

Looks good. r=LpSolit

Comment 3

[Max Kanat-Alexander]

Thanks! :-)

Checking in editkeywords.cgi;
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v  <--  editkeywords.cgi
new revision: 1.46; previous revision: 1.45
done
Checking in Bugzilla/Object.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Object.pm,v  <--  Object.pm
new revision: 1.27; previous revision: 1.26
done