460376 - checksetup.pl instructions to install missing Perl modules are hardcoded in english

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Frédéric Buclin]

Install a l10n package, e.g. the french one, and run checksetup.pl:

[root@localhost bugzilla]# ./checksetup.pl --check-modules       
* Bugzilla 3.3 avec Perl 5.10.0                                  
* sur Linux 2.6.27-desktop586-0.rc8.2mnb #1 SMP Thu Oct 2 05:52:21 EDT 2008

Vérification des modules Perl…
Vérification de              CGI.pm (v3.33)   ok: v3.39 trouvé 
Vérification de            TimeDate (v2.21)   ok: v2.22 trouvé 
Vérification de            DateTime (v0.28)   ok: v0.4304 trouvé 
Vérification de           PathTools (v0.84)   ok: v3.2501 trouvé 
Vérification de                 DBI (v1.41)   ok: v1.607 trouvé  
Vérification de    Template-Toolkit (v2.15)   ok: v2.19 trouvé   
Vérification de          Email-Send (v2.00)   ok: v2.192 trouvé  
Vérification de          Email-MIME (v1.861)  ok: v1.861 trouvé  
Vérification de Email-MIME-Modifier (v1.442)  ok: v1.442 trouvé  

Vérification des modules Perl DBD disponibles…
Vérification de              DBD-Pg (v1.45)   ok: v2.10.3 trouvé 
Vérification de           DBD-mysql (v4.00)   ok: v4.008 trouvé  
Vérification de          DBD-Oracle (v1.19)    non trouvé        

Les modules Perl suivants sont optionnels :
Vérification de                  GD (v1.20)   ok: v2.41 trouvé 
Vérification de               Chart (v1.0)    ok: v2.4.1 trouvé 
Vérification de         Template-GD (tout)    ok: v1.56 trouvé  
Vérification de          GDTextUtil (tout)    ok: v0.86 trouvé  
Vérification de             GDGraph (tout)    ok: v1.44 trouvé  
Vérification de            XML-Twig (tout)    ok: v3.32 trouvé  
Vérification de          MIME-tools (v5.406)  ok: v5.427 trouvé 
Vérification de         libwww-perl (tout)    ok: v5.814 trouvé 
Vérification de         PatchReader (v0.9.4)  ok: v0.9.5 trouvé 
Vérification de          PerlMagick (tout)     non trouvé       
Vérification de           perl-ldap (tout)    ok: v0.38 trouvé  
Vérification de         Authen-SASL (tout)    ok: v2.12 trouvé  
Vérification de          RadiusPerl (tout)     non trouvé       
Vérification de           SOAP-Lite (tout)    ok: v0.710.08 trouvé 
Vérification de         HTML-Parser (v3.40)   ok: v3.56 trouvé     
Vérification de       HTML-Scrubber (tout)    ok: v0.08 trouvé     
Vérification de Email-MIME-Attachment-Stripper (tout)    ok: v1.315 trouvé 
Vérification de         Email-Reply (tout)    ok: v1.202 trouvé
Vérification de            mod_perl (v1.999022)  non trouvé
**********************************************************************
* OPTIONAL MODULES                                                   *
**********************************************************************
* Certain Perl modules are not required by Bugzilla, but by          *
* installing the latest version you gain access to additional        *
* features.                                                          *
*                                                                    *
* The optional modules you do not have installed are listed below,   *
* with the name of the feature they enable. If you want to install   *
* one of these modules, just run the appropriate command in the      *
* "COMMANDS TO INSTALL" section.                                     *
**********************************************************************

***********************************************************************
* MODULE NAME * ENABLES FEATURE(S)                                    *
***********************************************************************
*  PerlMagick * Optionally Convert BMP Attachments to PNGs            *
*  RadiusPerl * RADIUS Authentication                                 *
*    mod_perl * mod_perl                                              *
***********************************************************************
COMMANDS TO INSTALL:

     PerlMagick: /usr/bin/perl5.10.0 install-module.pl Image::Magick
     RadiusPerl: /usr/bin/perl5.10.0 install-module.pl Authen::Radius
       mod_perl: /usr/bin/perl5.10.0 install-module.pl mod_perl2

Pour essayer d'installer automatiquement chaque module obligatoire et optionnel
en une seule commande, exécutez :

  /usr/bin/perl5.10.0 install-module.pl --all


Note that the **********************************************************************
* OPTIONAL MODULES                                                   *
**********************************************************************
section is in english, because this message is hardcoded in Bugzilla::Install::Requirements::print_module_instructions(). That's not the single message being hardcoded, Requirements.pm is full of such messages. They should all be moved into template/en/default/setup/strings.txt.tmpl to give us a chance to translate them in our respective l10n packages.

Comment 1

[Frédéric Buclin]

And here is the remaining part, without --check-modules:

Reading ./localconfig...
Vérification de           DBD-mysql (v4.00)   ok: v4.008 trouvé 
Checking for           MySQL (v4.1.2)  ok: found v5.0.67          

Correction des permissions d'accès aux fichiers…


2 things about this last part:

- Checking for   MySQL (v4.1.2)  ok: found v5.0.67 must be in french;

- Vérification / trouvé instead of Vérification / trouvé ?! I saw this problem for a long time, but never took the time to file a bug for it. That's probably a different issue, but I post it here for now. wurblzap, any idea? I suppose you use "gefunden" auf Deutsch, so you don't see this problem? Maybe the encoding changed meanwhile?

Comment 2

[Max Kanat-Alexander]

That second thing you're experiencing is probably bug 382398.

Comment 3

[Max Kanat-Alexander]

This is more of a missing enhancement than a bug.

Comment 4

[Vitaly Fedrushkov]

(In reply to comment #2)
> That second thing you're experiencing is probably bug 382398.

In this case, console apparently has all needed glyphs, as seen in comment 0.  However, generic and database modules may operate in different UTF-8 environment, thus leading to extra conversion in the latter.

In ISO 8859-1, Ã is 0xC3 and © is 0xA9.  Unicode Character 'LATIN SMALL LETTER E WITH ACUTE' (U+00E9) é is exactly 0xC3A9 in UTF-8.

Comment 5

[Marc Schumann [:Wurblzap]]

The output stream must be converted to what the console understands. For Windows, this can be done by saying

   binmode(STDOUT, ':encoding(cp850)');
   binmode(STDERR, ':encoding(cp850)');

For other consoles, we probably need to find out which encoding the console actually expects.

Comment 6

[Max Kanat-Alexander]

Please put those comments on bug 382398.

Comment 7

[Max Kanat-Alexander]

Attachment: v1

Okay, here's the code, I just have to test this on Windows and then it's good.

Comment 8

[Max Kanat-Alexander]

Attachment: v2

Okay, fixed some things for Windows. Granting myself review as module owner.

Comment 9

[Max Kanat-Alexander]

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.58; previous revision: 1.57
done
Checking in template/en/default/setup/strings.txt.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/setup/strings.txt.pl,v  <--  strings.txt.pl
new revision: 1.9; previous revision: 1.8
done