Closed Bug 460956 Opened 16 years ago Closed 16 years ago

XML and XMLList objects do not implement toSource()

Categories

(Rhino Graveyard :: E4X, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hannesw, Unassigned)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.3) Gecko/2008092510 Ubuntu/8.04 (hardy) Firefox/3.0.3
Build Identifier: 

XML and XMLList do not currently implement the toSource() method. The inherited toSource() produces a bogus JavaScript object:

x = <x>foo</x>
x.toSource()
({0:{}})


Reproducible: Always
Attached patch Fixes this bugSplinter Review
Implement toSource for XML and XMLList objects.
Committed patch: 

Checking in xmlimplsrc/org/mozilla/javascript/xmlimpl/XML.java;
/cvsroot/mozilla/js/rhino/xmlimplsrc/org/mozilla/javascript/xmlimpl/XML.java,v  <--  XML.java
new revision: 1.28; previous revision: 1.27
done
Checking in xmlimplsrc/org/mozilla/javascript/xmlimpl/XMLList.java;
/cvsroot/mozilla/js/rhino/xmlimplsrc/org/mozilla/javascript/xmlimpl/XMLList.java,v  <--  XMLList.java
new revision: 1.28; previous revision: 1.27
done
Checking in xmlimplsrc/org/mozilla/javascript/xmlimpl/XMLObjectImpl.java;
/cvsroot/mozilla/js/rhino/xmlimplsrc/org/mozilla/javascript/xmlimpl/XMLObjectImpl.java,v  <--  XMLObjectImpl.java
new revision: 1.24; previous revision: 1.23
done
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: