Closed
Bug 461006
Opened 16 years ago
Closed 16 years ago
Update DOMi to overlay the new Sunbird main window uri
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: ssitter, Assigned: ssitter)
References
Details
Attachments
(1 file)
2.40 KB,
patch
|
sdwilsh
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Bug 290747 moved around several files and repackaged them to different locations. As the result the main window uri changed from "chrome://calendar/content/calendar.xul" to "chrome://sunbird/content/calendar.xul". This patch takes care that DOMi correctly overlays in Sunbird nightly builds.
Attachment #344141 -
Flags: review?(sdwilsh)
Comment 1•16 years ago
|
||
What version number does this correspond to? What happens with the older version?
Assignee | ||
Comment 2•16 years ago
|
||
DOMi only support the Sunbird 1.0pre (Gecko 1.9.1) nightly builds (Bug 459404). Therefore I think it's OK to drop support for the few nightly builds created between 2008-10-12 and now and just support the future nightly builds.
Comment 3•16 years ago
|
||
ok - is there no version change?
Assignee | ||
Comment 4•16 years ago
|
||
The version change to 1.0pre was some weeks ago when calendar development switched from mozilla1.8 branch to comm-central/mozilla-central. That change was added with Bug 459404 to DOMi. Or do you refer to something else?
Comment 5•16 years ago
|
||
I was just making sure that calendar hadn't actually had a version bump when this happened, but I suppose with a version like 1.0pre, you don't have much to work with.
Comment 6•16 years ago
|
||
Comment on attachment 344141 [details] [diff] [review] use new uri for Sunbird main window [Checkin: Comment 8] r=sdwilsh
Attachment #344141 -
Flags: superreview?(neil)
Attachment #344141 -
Flags: review?(sdwilsh)
Attachment #344141 -
Flags: review+
Updated•16 years ago
|
Attachment #344141 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 7•16 years ago
|
||
I don't have checkin permissions therefore I'd like you to checkin the changes for me.
Keywords: checkin-needed
Comment 8•16 years ago
|
||
Comment on attachment 344141 [details] [diff] [review] use new uri for Sunbird main window [Checkin: Comment 8] http://hg.mozilla.org/dom-inspector/rev/e18f3c4a1ca1
Attachment #344141 -
Attachment description: use new uri for Sunbird main window → use new uri for Sunbird main window
[Checkin: Comment 8]
Updated•16 years ago
|
Assignee: nobody → ssitter
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•