461309 - make clean fails in debug builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

Doing a make -f client.mk clobber in linux now fails for debug builds.

I've been able to reproduce this on up to date centos5 vms but not with somewhat out of date centos5 physical machines.

gmake[2]: Entering directory `/work/mozilla/builds/1.9.1/mozilla/firefox-debug/browser/installer'
Makefile:70: *** you need a "--enable-static or --enable-libxul" build to package a build.  Stop.

I changed the mozconfig to include --disable-installer but it had no effect.

I'm pretty sure bug 422991 is the cause.

mozconfig:

. $topsrcdir/browser/config/mozconfig

CPU=`cat /proc/cpuinfo | grep 'processor.*: [0-9]*' | wc -l`
let J=$CPU+1
if [[ $J -gt 4 ]]; then let J=4; fi


mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/firefox-debug
mk_add_options MOZ_MAKE_FLAGS=-j${J}
mk_add_options MOZ_CO_PROJECT=browser

ac_add_options --enable-application="browser"
ac_add_options --disable-optimize
ac_add_options --enable-debugger-info-modules=all

ac_add_options --enable-debug
ac_add_options --disable-tests
#ac_add_options --enable-canvas
#ac_add_options --enable-svg
#ac_add_options --enable-pango
ac_add_options --enable-default-toolkit=cairo-gtk2
ac_add_options --disable-static
ac_add_options --enable-shared
#ac_add_options --enable-places

ac_add_options --disable-crashreporter
ac_add_options --disable-installer
ac_add_options --disable-jemalloc
ac_add_options --with-valgrind

Comment 1

[Mike Hommey [:glandium]]

I'd say everything between lines 54 and 67 in 
http://mxr.mozilla.org/mozilla-central/source/browser/build.mk#54

should be depending on MOZ_INSTALLER, for a starter...

Mand maybe http://mxr.mozilla.org/mozilla-central/source/browser/installer/Makefile.in#70 should not really error out. A warning may suffice.

Comment 2

[Bob Clary [:bc] (inactive)]

I see this also on Mac OS X intel 10.5.5 but not it seems on Mac OS X intel kernel 10.4.11

Comment 4

[Jim Blandy :jimb]

I can reproduce this on Linux, with M-C trunk.

Comment 5

[Jim Blandy :jimb]

Attachment: Bug 461309: Let browser/installer/Makefile.in permit 'make clean' in debug builds.

[Not sure I've got all the angles here, but this does seem to work.]

The 'clean' and 'distclean' targets may need to recur into
browser/installer/Makefile.in.  Don't run afoul of the code to protect
us from packaging debugging builds.

Comment 6

[Benjamin Smedberg]

Comment on attachment 348649 [details] [diff] [review]
Bug 461309: Let browser/installer/Makefile.in permit 'make clean' in debug builds.

Boy that's ugly, but I hate to bikeshed over a cleaner error message.

Comment 7

[Jim Blandy :jimb]

Well, a bikeshed discussion would require me to have preferences that conflict with yours, which isn't the case.  :)  Just say how you think it should be, and I'll make it so.

Comment 8

[Jim Blandy :jimb]

Landed: 86e908446af4

Comment 9

[Phil Ringnalda (:philor)]

Being a bikeshedder of the first order, I'm going to stomp on your message in bug 469789 (which seems only fair, since you bitrotted me by traveling back in time and patching this before I had a chance to push mine) - I'm aiming at getting rid of any mention of "--enable-static" since for Firefox that dies in configure, and mentioning every single thing they might have done, including --enable-shared, to wind up with a non-libxul build, in the vain hope of not seeing any more bugs where someone shrieks about how Firefox can't be built on Linux, you idiots!!

Comment 10

[Jim Blandy :jimb]

That's a-okay with me. :)