Closed Bug 461422 Opened 16 years ago Closed 16 years ago

Menulists don't size properly until they have been opened

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: enndeakin)

References

Details

(Keywords: regression)

Attachments

(1 file)

Patch that Enn gave me over IRC
559 bytes, patch
neil
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
Bug #450990 added treeitem and menulist to the list of tags for which content should be lazily generated. Unforunately menulists need their first level to be generated so that they can size to their popup.
...which I have verified seems to resolve the problem.
Attachment #344538 - Flags: superreview?(bzbarsky)
Attachment #344538 - Flags: review+
Attachment #344538 - Flags: superreview?(bzbarsky) → superreview+
treeitems were also not generated lazily this way I think. Would this be something that could cause a problem also?
I think my summary may have been incorrect; what may have happened was that the old code would always generate menulists because they were the root node.
As stefanh pointed out on IRC this also affects our charset menus.
I mean menulists of course; we have real charset menus too.
Is there more to do here?
I wanted to give you the chance to check the patch in as it was your idea.
Pushed changeset 157abfbcb96e to mozilla-central.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
sdwilsh backed this out as http://hg.mozilla.org/mozilla-central/rev/8b08744c500c because it was checked in while the tree was closed.  --> Reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
f923f7a759e2
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: