461440 - ASSERTION: Fix the caller, this type of node can never contain children.: 'parentTagEnum < NS_HTML_TAG_MAX'

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase

STEPS TO REPRODUCE
1. load the attached testcase

ACTUAL RESULT
###!!! ASSERTION: Fix the caller, this type of node can never contain children.: 'parentTagEnum < NS_HTML_TAG_MAX', file /usr/moz/hg1/editor/libeditor/html/nsHTMLEditor.cpp, line 4183

Comment 1

[Jesse Ruderman]

The testcase in bug 382210 also triggers this assertion.

Comment 2

[Jesse Ruderman]

Still happens on trunk (not fixed in bug 414178).

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

This is also hit in editing tests; possibly through the DocumentFragment case in nsEditor::CanContainTag.

Comment 4

[(no longer active)]

Comment on attachment 649204 [details] [diff] [review]
Patch v1

Review of attachment 649204 [details] [diff] [review]:
-----------------------------------------------------------------

I think the right fix to this is to OR the condition of the assertion with parentTagEnum == eHTMLTag_userdefined (assuming that that is what HTMLAtomTagToId returns).

Comment 5

[(no longer active)]

Comment on attachment 649204 [details] [diff] [review]
Patch v1

Ms2ger tells me that CanContain already asserts what I asked for here!

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/753b39a6e957