462222 - getZOrderDOMWindowEnumerator broken on Linux and Mac

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(no longer active)]

getZOrderDOMWindowEnumerator seems to be working only on Windows.  We need to adjust the #ifdefs at the following places accordingly:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4267

http://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserContentHandler.js#253

Comment 1

[Justin Dolske [:Dolske]]

Bug 456439 will be adding another copy of this code to nsBrowserGlue.js as well.

Comment 2

[Mike Connor [:mconnor]]

Yeah... we need to fix this.

bug 156333 is the longstanding Linux bustage.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

As per comment 2, dunno why he didn't flip the flag himself ;)

Comment 4

[Dave Townsend [:mossop]]

Looks like this isn't going to get fixed on Mac anytime soon. Ehsan, do you have a good understanding of the changes we need to handle this?

Comment 5

[(no longer active)]

Without the dependencies being fixed, there is nothing to do here.  This bug is mostly about removing the conditional code inside of BROKEN_WM_Z_ORDER blocks, once the dependencies are fixed.

Given that bug 450576 is blocking1.9.1-, and bug 156333 is wanted1.9.1+, I'm not sure how this one ended up being blocking1.9.1+.  Turning the flag to ? for reconsideration.

Comment 6

[Dave Townsend [:mossop]]

bug 450576 was previously blocking but josh has concluded that it is too risky to take for 1.9.1, so we can't block here either.

Comment 7

[Mike Connor [:mconnor]]

Pretty sure we still have to fix the ifdefs so that we don't assume mac will work...

Comment 8

[Dão Gottwald [:dao]]

Attachment: don't assume that mac works

this is what nsPrivateBrowsingService.js already does

Comment 9

[:Gavin Sharp [email: [e-mail]]]

The patch in bug 462478 would make this one simpler.

Comment 10

[Dão Gottwald [:dao]]

Attachment: updated (checked in)

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 356633 [details] [diff] [review]
updated (checked in)

thanks!

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 356633 [details] [diff] [review]
updated (checked in)

http://hg.mozilla.org/mozilla-central/rev/d765319f547d

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a05e3e37e030

Comment 13

[Mike Connor [:mconnor]]

This is "fine" for now, but we should stay on top of this for .next

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Connor, this is blocking, but there's a checked in patch? I think we want to:

 - close this bug
 - open a new bug with a description of what has to change
 - make that bug blocking, if you believe it needs to be
 - make sure that bug has an assignee

Assigning this to mconnor for now to handle.

Comment 15

[Johnathan Nightingale [:johnath]]

After further discussion with mconnor - this doesn't block. mconnor does still believe we should fix it, instead of just assuming broken z order everywhere except windows. It may well belong in its own bug instead of here, but either way, marking it blocking-.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

while on Mac it is working it still fails on Linux. Is there anything we can do here to get this enumerator fixed?

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like this is working now across platforms. Ehsan, can you verify that?

Comment 18

[(no longer active)]

The code in question doesn't exist any more.

Comment 19

[Dão Gottwald [:dao]]

It still exists. (See the URL field.)

Comment 20

[(no longer active)]

Oh, right, it was moved... by me! ;-)

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What I wanted to say in comment 17 is that we have a test for Mozmill which makes use of the getZOrderDOMWindowEnumerator and works well across platforms. So I wonder if those remaining ifdef declarations are still necessary.

Comment 22

[Mark Hammond [:markh] [:mhammond]]

According to bug 874566, the ZOrder enumerator now works on Mac, so updating this accordingly.

Comment 23

[Dão Gottwald [:dao]]

(In reply to Mark Hammond (:markh) from comment #22)
> According to bug 874566, the ZOrder enumerator now works on Mac, so updating
> this accordingly.

Please continue that discussion in bug 450576. Once resolved, we should update this bug, and file a bug on updating our BROKEN_WM_Z_ORDER logic.

Comment 24

[:Gavin Sharp [email: [e-mail]]]

This bug doesn't seem useful anymore.

Comment 25

[:Gavin Sharp [email: [e-mail]]]

I morphed bug 891194 into being about fixing BROKEN_WM_Z_ORDER

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, so this issue got fixed 4 years ago, right? I ask because MDN still refers to this bug and says that it is broken on Linux and OS X. 

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIWindowMediator#getZOrderDOMWindowEnumerator()

Comment 27

[Dão Gottwald [:dao]]

You're misunderstanding what this bug is about. It's not about whether getZOrderDOMWindowEnumerator is broken but where it's broken.

Comment 28

[Dão Gottwald [:dao]]

Somebody should update MDN to say that it's broken on Linux and point to bug 156333 rather than this bug. Unfortunately editing MDN requires a github account these days and I don't have one.

Comment 29

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Dão Gottwald [::dao] from comment #28)
> Somebody should update MDN to say that it's broken on Linux and point to bug
> 156333 rather than this bug. Unfortunately editing MDN requires a github
> account these days and I don't have one.

Thanks Dao. Sheppy, can you or someone else please update the above referenced page? Thanks.