462823 - make |test_interface()| function in |test_recur.js| more robust

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect, P2)

Description

[Daniel Boelzle [:dbo]]

Those tests rely on a certain order of the RRULE's parameters which could change.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This is as far as I think we should fix the test for now. I've replaced exact checks with string/regex checks and it seems to be working, both for ical.js and libical.

This patch also removes enabling ical.js which I accidentally added in bug 973651.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 3

[Matthew Mecca [:mmecca]]

Comment on attachment 8384279 [details] [diff] [review]
Fix - v1

Review of attachment 8384279 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mmecca

::: calendar/test/unit/test_recur.js
@@ +377,5 @@
>  
>      // deleteRecurrenceItemAt
>      rinfo.deleteRecurrenceItemAt(1);
>      itemString = item.icalString;
> +    dump(itemString);

dump left in intentionally?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Matthew Mecca [:mmecca] from comment #3)

> > +    dump(itemString);
> 
> dump left in intentionally?

Nope, thanks for catching that.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 3d40333df6e2