463165 - Check box of about:sessionrestore is invisible with High-Contrast theme of Windows.

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Masahiro YAMADA]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1b2pre) Gecko/20081104 Minefield/3.1b2pre

Now, check box always uses single image that contains only black and transparent.
When setting desktop design of Windows sets Highlight Color as Black, checkbox is invisible.

Reproducible: Always

Steps to Reproduce:
1.Change Your desktop theme as High Contrast #1
2.Show some webpage with firefox.exe
3.Stop firefox.exe from Task Manager.
4.Run firefox.exe again

Actual Results:  
Checkbox is not visible

Expected Results:  
Checkbox should be visible.

Comment 1

[Simon Bünzli]

Alex: Please keep this in mind when asking for new graphics. AFAIK in other places we had a whitish outline around black shapes (e.g. for the dropdown markers).

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah, we are usually pretty good at not messing this up.  That checkbox image has been around for a really long time, but the problem never came up because this is the first time we are using it in Firefox (as far as I know).  I'll get this fixed.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Replacement cbox-check.gif

this file needs to replace the file currently at:

/source/toolkit/themes/winstripe/global/checkbox/cbox-check.gif

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Requesting blocking due to accessibility issue with session restore, and the fix is just dropping in the attached new icon.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: new icon

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 372984 [details] [diff] [review]
new icon

cbox-check-dis.gif also uses only one shade of gray, but that seems less critical.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

>cbox-check-dis.gif also uses only one shade of gray, but that seems less
>critical.

as far as I know we aren't currently using that image in Firefox, and the one shade of grey it uses should appear ok on a black background.  Either way this get's solved by the broader bug 462618 to use native check boxes.

Comment 8

[Dão Gottwald [:dao]]

It's used in about:sessionrestore next to "Window X" when some tabs are unchecked. I suppose it would be invisible or nearly invisible with some of the Classic flavors, but I haven't tested it.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/752c18ea8cdb
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1eb81c6e8aa2