Closed
Bug 463958
Opened 16 years ago
Closed 16 years ago
Remove nsEventStateManager::ForceViewUpdate
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
2.70 KB,
patch
|
roc
:
review+
roc
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
With Steven's patch for bug 428070 scrolling the testcase is pretty good. However now Shark shows nsEventStateManager::ForceViewUpdate in the profile when scrolling the page using mousewheel. I think we could just remove the method. I tested normal pages and also about:config and other xul:trees in the UI. Seems like bryner added that method year 2000 to fix some xul:tree problems. Unfortunately the commit message doesn't contain link to the bug. I guess the relevant bug is bug 43710 (no patches there :( ). With this change and bug 428070 http://news.opensuse.org/2007/10/04/announcing-opensuse-103-gm/ becomes pretty fast to scroll even with mousewheel on OSX.
Attachment #347215 -
Flags: superreview?(roc)
Attachment #347215 -
Flags: review?(roc)
Attachment #347215 -
Flags: superreview?(roc)
Attachment #347215 -
Flags: superreview+
Attachment #347215 -
Flags: review?(roc)
Attachment #347215 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Attachment #347215 -
Flags: approval1.9.1?
Comment 1•16 years ago
|
||
Comment on attachment 347215 [details] [diff] [review] proposed patch a191=beltzner I think we'll want to really watch hard for unexpected functional regressions here, so when you land this, please make sure to mention it in the weekly development notes so we can all be aware. Just nervous about removing a forced view update that we know little about :(
Attachment #347215 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [needs-1.9.1-landing]
Updated•16 years ago
|
Assignee: nobody → Olli.Pettay
Version: unspecified → Trunk
Assignee | ||
Comment 3•16 years ago
|
||
Will add some comment to status meeting wiki.
Updated•16 years ago
|
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•