465019 - Copy, cut, paste from context menu in calendar views do not work

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Martin Schröder [:mschroeder]]

Copy, cut, paste from context menu in calendar views do not work, but the corresponding key shortcuts (Ctrl+[C,X,V]) work flawlessly.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed using Lightning 1.0pre (BuildID: 20090308052121) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090308 Shredder/3.0b3pre.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 366400 [details] [diff] [review]
Fix - v1

Paste still doesn't work with the patch applied. In addition I'd like to know why Lightning seems to require the additional command attribute. Why does it work in Sunbird without it? Why do the other entries in the context menu work without it?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

(In reply to comment #3)
> (From update of attachment 366400 [details] [diff] [review])
> Paste still doesn't work with the patch applied. 

Fixed paste, this worked from the item context menu but not from the view context menu.

> In addition I'd like to know
> why Lightning seems to require the additional command attribute. Why does it
> work in Sunbird without it? Why do the other entries in the context menu work
> without it?

This has been puzzling me for quite some time. We have had this problem while working with menuitems many times before, but here's my partial theory:

command= makes sure that the "oncommand" attribute is taken over from the actual command.
observes= usually takes over quite some attributes, but this doesn't always seem to be the case for oncommand.

I have no idea why there is a difference between Sunbird and Lightning.

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 367469 [details] [diff] [review]
Fix - v2

r=ssitter

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/6db3c7566f86>

-> FIXED

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".