46525 - UMR in OpenProcessToken called from PR_NT_InitSids [ntsec.c:80]

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Daniel Bratell]

When running Mozilla today on Windows 2000 I notice an Unintialized Memory Read 
in OpenProcessToken. It's the last parameter hToken that's not initialized. As 
far as I can see we shouldn't have to either but it's probably a bug in 
Windoes. Maybe we could null it or something just to silence Purify. For the 
moment, it's the only warning during startup in my local tree. (I have some code 
that's not checked in yet.)

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

Does the proposed patch silence Purify?

Comment 3

[Daniel Bratell]

Yes it does. 

Comment 4

[Wan-Teh Chang]

I checked in the patch on the main trunk.
/cvsroot/mozilla/nsprpub/pr/src/md/windows/ntsec.c, revision 3.5

Comment 5

[Daniel Bratell]

I don't see this fixed in Mozilla (Seamonkey). Is this using another version of 
NSPR than the one you fixed it on?

Comment 6

[Wan-Teh Chang]

Yes, Mozilla (SeaMonkey) is using the NSPRPUB_CLIENT_BRANCH
of NSPR.  I checked in the fix on the main trunk of NSPR.

Only critical bug fixes can be checked in on the NSPRPUB_CLIENT_BRANCH.