Closed Bug 465455 Opened 16 years ago Closed 16 years ago

XHR should use the charset it will send for serializing documents

Categories

(Core :: DOM: Core & HTML, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Attached patch Fix like so (obsolete) — Splinter Review
Realized this is a problem when working on bug 464958.

Not sure how to test this: would need a document with no inputEncoding whose document charset isn't UTF-8.  I guess I could createInstance one or something, but I don't want to depend on that.
Attachment #348696 - Flags: superreview?(jonas)
Attachment #348696 - Flags: review?(jonas)
Attachment #348696 - Flags: superreview?(jonas)
Attachment #348696 - Flags: superreview+
Attachment #348696 - Flags: review?(jonas)
Attachment #348696 - Flags: review+
Comment on attachment 348696 [details] [diff] [review]
Fix like so

We should take this for 1.9.1 too, to be safe.
Attachment #348696 - Flags: approval1.9.1?
Priority: -- → P2
Attachment #348696 - Flags: approval1.9.1? → approval1.9.1+
Attached patch mq patchSplinter Review
Assignee: nobody → bzbarsky
Attachment #348696 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Pushed http://hg.mozilla.org/mozilla-central/rev/db3ad9fd7b65
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b2
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: