465717 - WCAP calendars are not available in lightning/sunbird build 20081118

Status: VERIFIED FIXED

(Calendar :: Provider: WCAP, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- use lightning/sunbird 20081117 and subscribe to a wcap calendar
- update this profile with the 20081118 build
- restart the application

RESULT:
=======

- the wcap calendar is marked 'not available' in the calendar list
- error at startup in the error console:

Warning: There has been an error reading data for calendar: Andreas Treumann.  However, this error is believed to be minor, so the program will attempt to continue. Error code: 0x80004005. Description: NS_ERROR_FAILURE

Warning: There has been an error reading data for calendar: Andreas Treumann.  However, this error is believed to be minor, so the program will attempt to continue. Error code: READ_FAILED. Description: READ_FAILED
EXPECTED RESULT:
================

- the wcap calendar should be available

REPRODUCIBLE:
=============

- always

Regression possible caused by checkin bug 436047.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 349178 [details] [diff] [review]
fix - v1

>-            return cal.ical.subcompentIterator(aComponent, compType);
Oops, sorry about that :-}

>     for (let subComp in cal.ical.calendarComponentIterator(icalRootComp, componentType)) {
>-        if (++count > maxResults) {
>-            break;
>-        }
No checking for maxResults anymore?

r=philipp

Comment 3

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a7ac7311d9e0>

-> FIXED

Comment 4

[Daniel Boelzle [:dbo]]

(In reply to comment #2)
> No checking for maxResults anymore?
Sure, maxResults is passed to the server as well as checked when expanding occurrences.

Comment 5

[Andreas Treumann]

Checked in lightning and sunbird buils 20081124 -> VERIFIED.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".