465833 - folder pane context open menu item doesn't open correctly

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David :Bienvenu]

If I do a folder pane context menu open command, it opens a new window, but in the wrong folder view (favorites instead of all). That's with a partial patch that fixes other issues...

Comment 1

[David :Bienvenu]

Attachment: proposed fix

this takes the interesting parts of the folder pane columns patch, and adds the removal of the prefs from all-thunderbird.js. Now, we remember the last view used, and open in new window works.

Comment 2

[David :Bienvenu]

Attachment: correct patch

Comment 3

[David :Bienvenu]

Attachment: don't get rid of folder version

jminta correctly points out that we can't get rid of folder version pref because that will break migration from 1.5

Comment 4

[Joey Minta]

Comment on attachment 349081 [details] [diff] [review]
don't get rid of folder version

+          if (gFolderTreeView._rowMap.length)
+            gFolderTreeView.selectFolder(gFolderTreeView._rowMap[0]._folder);
+         }
The closing brace looks poorly aligned.

I'm not wild about reviewing my own code, but if you can't find someone else with a spare 15 minutes, r=jminta

Comment 5

[Joey Minta]

Note also that this'll create the slightly unintuitive result that the second window will be opened with the persisted open-map from the last restart, rather than the current open-map. We might want to flush the json to disk before opening, or come up with a way to pass the open-map to the new window.

Comment 6

[David :Bienvenu]

well, for the part you did, you're just reviewing that I didn't mess up extracting the patch. I'll put us down as both reviewing it...

Comment 7

[David :Bienvenu]

fix checked in - this will also fix bug 465267