46597 - connection refused does not give any graphical notification

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P3)

Description

[namos]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; SunOS 5.8 sun4u; en-US; m17) Gecko/20000725
BuildID:

when the web server refuses connections, error message is only printed in the
command-line window that started mozilla, the browser sits there like nothing
happened

Reproducible: Always
Steps to Reproduce:
1.browse a host:port that refuses connections

Comment 1

[ckritzer (gone)]

Mass update:  changing qacontact to [e-mail]

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Using build from last week I do not see this kind of behaviour neither on NT or
Linux (tried http://bugzilla.mozilla.org with various ports). Is it only
happening with a Solaris build, or can you reproduce it with some other system?

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Since I cannot reproduce this (i.e. I always get a dialog saying connection 
refused) I am marking this WORKSFORME. If you still see this with recent build, 
please update this bug report.

Comment 4

[Loco]

Updating QA Contact.

Comment 5

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 6

[Madhur Bhatia]

QA contact updated

Comment 7

[psfales]

We've observed that this is not a problem on Linux, but it definitely occurs on
solaris.  Using truss, we found that if we attempt to connect to localhost, the
connect() system call returns ECONNREFUSED and the dialog box comes up.  However,
when we connect to a site over the network, connect() returns EINPROGRESS and
the behavior seen by the user is that the request is silently ignored.

Comment 8

[joki (gone)]

Could be a Solaris bug, not event handling either way, though.  Not sure why 
this was originally assigned to me.  If this is reopened it should probably be 
on Networking.

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

From Peter Fales:

The problem is still occurring with the 0.9.3.  (The build ID
is 2001080315, but I don't know how meaningful that is since I built
it myself).

I am reopening, and will assign to networking.

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Sending to correct owners.

Comment 11

[benc]

+qawanted: I'm working on getting a Solaris workstation working. This can be
confirmed if someone else w/ Solaris sees it too.

Comment 12

[Calvin Liu]

if you want to reproduce this bug, don't use any proxy.
you may follow this way: use mozilla to visit a host that NOT running any webserver.
it seems nothing happened but ie will return an error page says "DNS error".

Comment 13

[Calvin Liu]

Strange! I lost the bug in mozilla 0.9.4!

I found there is already an error handler in docshell/base/nsWebShell.cpp.
If we enable the keyword server in [preferences]->[navigator]->[smart browsing]-
>[keyword], mozilla will redirect to keyword server after refused by current 
server. Otherwise, it'll prompt a dialog that says:"The connection to ... was 
refused.".

The only difference is some version of mozilla returns aStatus as 0x804B0005 
here(NS6 definitely returns this value), but actually it should be 0x804B000D. 
I don't know why.

As follows:
http://lxr.mozilla.org/seamonkey/source/docshell/base/nsWebShell.cpp#838

nsresult nsWebShell::EndPageLoad(nsIWebProgress *aProgress,
                                 nsIChannel* channel,
                                 nsresult aStatus)
{
......
  //
  // If the page load failed, then deal with the error condition...
  // Errors are handled as follows:
  //   1. Send the URI to a keyword server (if enabled)
  //   2. If the error was DNS failure, then add www and .com to the URI
  //      (if appropriate).
  //   3. Throw an error dialog box...
  //
......
    //
    // First try sending the request to a keyword server (if enabled)...
    //
    if(aStatus == NS_ERROR_UNKNOWN_HOST ||
       aStatus == NS_ERROR_CONNECTION_REFUSED ||
       aStatus == NS_ERROR_NET_TIMEOUT)
    {
      PRBool keywordsEnabled = PR_FALSE;

      if(mPrefs) {
        rv = mPrefs->GetBoolPref("keyword.enabled", &keywordsEnabled);
        if (NS_FAILED(rv)) return rv;
      }
......
    //
    // Doc failed to load because we couldn't connect to the server.
    // throw a connection failure dialog
    //
    else if(aStatus == NS_ERROR_CONNECTION_REFUSED) {
......
      nsCOMPtr<nsIPrompt> prompter;
......
      prompter->Alert(nsnull, msg);
      nsTextFormatter::smprintf_free(msg);
    }
  return NS_OK;
}

Comment 14

[Calvin Liu]

Can we close this bug? I suggest to do so.

Comment 15

[psfales]

I'm not seeing the problem anymore.  I agree that it can be closed.

Comment 16

[neeti]

wfm per comments above

Comment 17

[neeti]

need to change status to wfm

Comment 18

[neeti]

wfm

Comment 19

[benc]

+verifyme - I have a Sun at a remote site, but if anyone wants to verify right
now, please do.

Comment 20

[benc]

reporter: can you verify this works now?

Comment 21

[psfales]

I'm not the original reporter, but I saw the bug in 0.9.3.  It's working for me now.