Closed
Bug 466102
Opened 16 years ago
Closed 16 years ago
layout/style/test/test_bug379440.html should not depend on network resources
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
2.22 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I just tried running layout/style mochitests while my network connection was down again (thanks, Comcast), and noticed that layout/style/test/test_bug379440.html was waiting for www.example.com. We shouldn't be depending on www.example.com in mochitests.
Comment 1•16 years ago
|
||
Ah, yeah. That should be s/www\.// so as to hit the proxy.
Assignee | ||
Comment 2•16 years ago
|
||
I can't tell for sure that this fixes the problem, since the test only hangs when my machine thinks it has network but actually can't connect anywhere. However, based on looking at the proxy pref, it looks like it ought to fix it. And it's what you suggested. :-)
Attachment #349429 -
Flags: superreview?(bzbarsky)
Attachment #349429 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Comment 3•16 years ago
|
||
Comment on attachment 349429 [details] [diff] [review] patch Looks good. Thanks for patching it!
Attachment #349429 -
Flags: superreview?(bzbarsky)
Attachment #349429 -
Flags: superreview+
Attachment #349429 -
Flags: review?(bzbarsky)
Attachment #349429 -
Flags: review+
Assignee | ||
Comment 4•16 years ago
|
||
Fixed in mozilla-central (and thus also on mozilla-1.9.1): http://hg.mozilla.org/mozilla-central/rev/60a4dd420a65
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1
Assignee | ||
Updated•16 years ago
|
Target Milestone: mozilla1.9.1 → mozilla1.9.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•