466170 - Extra separator in View menu

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch-v1

There is an extra separator in the View Menu. The patch should fix the issue.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: after patch is applied

screenshot.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

mschroeder rightly points out that there is now a lack of separator in Lightning / Task mode with the patch applied.

Thoughts? (I'm thinking it's good to have an all-out relook of menuitems in a new look Thunderbird with integrated calendar, along with comprehensively refactored / audited shortcuts and accesskeys)

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 349432 [details] [diff] [review]
patch-v1

We need some mode-magic for <menuseparator id="before-today-pane"/>
, and a small change to <menuseparator id="before-task-View-Section" mode="mail,calendar,task"/>.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #3)
> (From update of attachment 349432 [details] [diff] [review])
> We need some mode-magic for <menuseparator id="before-today-pane"/>
> , and a small change to <menuseparator id="before-task-View-Section"
> mode="mail,calendar,task"/>.

Change to <menuseparator id="before-today-pane" add mode="calendar,task"/>?

I'm not so sure how to change before-task-View-Section.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Not working on this anytime soon, please feel free to take.

Comment 6

[Stefan Sitter [:ssitter]]

Confirmed on Windows XP too using Thunderbird 3.0b3pre (20090226) + Lightning 1.0pre (20090228).

Comment 7

[Stefan Sitter [:ssitter]]

Bug 456385 reorganizes the menus, adding dependency.

Comment 8

[Simon Paquet [:sipaq]]

This seems to have been fixed by the checkin for bug 456385. Gary, please reopen if you're still seeing this.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".