466288 - Make use of type="number" for textboxes representing integer preferences

Status: RESOLVED FIXED

(Calendar :: Preferences, enhancement)

Description

[Stefan Sitter [:ssitter]]

We should use type="number" for textboxes representing integer preferences to benefit from automatic input check, range checks, spinbuttons, ...
https://developer.mozilla.org/En/XUL/Textbox#a-textbox.type

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: fix

- uses type="number" on general, alarms and connection page
- limits event length and snooze time to 24 hours instead of just 999 minutes
- limits alarm offset to 32767 to avoid overflow similar to Bug 405650

Comment 2

[Martin Schröder [:mschroeder]]

Stefan, I think, the function validateNaturalNums (http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-ui-utils.js#594) should also be removed.

Comment 3

[Daniel Boelzle [:dbo]]

Comment on attachment 349561 [details] [diff] [review]
fix

Playing with the patch on Mac, my alarm prefs behave wrong, units toggle in a strange way.
Moreover I think validateNaturalNums() is obsolete then, you should remove it.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

This should do it. I went over all <textboxes>. I didn't set a max on the default event length, I don't see why the max should be 1440 (days). No doubt its unreasonable to make the default length that large, but why limit the user?

Comment 5

[Stefan Sitter [:ssitter]]

Comment on attachment 383153 [details] [diff] [review]
Fix - v2

The max attribute was set to prevent integer overflows as written above.

Daniel reviewed and denied the 1st patch, therefore he should review the 2nd too.

Comment 6

[Daniel Boelzle [:dbo]]

Philipp, did you spend some testing on this patch?

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, I've briefly looked at all number textboxes. I tested at least one of them to see if the max/min range works.

Comment 8

[Daniel Boelzle [:dbo]]

Comment on attachment 383153 [details] [diff] [review]
Fix - v2

r=dbo

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/08625567a7c7>

-> FIXED

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".