466726 - [redux] Make namespaces optional in VM and MMgc codebase

Status: VERIFIED WONTFIX

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Rishit Shah]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: 

Replace namespace declarations with macros so that they can be disabled for compilers (like ADS 1.2) that do not support them.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Rishit Shah]

Attachment: Patch for changes in files under MMgc [v1]

Comment 2

[Rishit Shah]

Attachment: Patch for changes in files under VM core and shell folders [v1]

Comment 3

[Lars T Hansen]

Comment on attachment 350069 [details] [diff] [review]
Patch for changes in files under VM core and shell folders [v1]

I get a few thousand compilation errors (under Xcode), it looks like many of these are caused by 'uint32' etc not being available all of a sudden.  This is after applying only this patch in isolation, not the patch for MMgc.

Comment 4

[Lars T Hansen]

Attachment: Patch for the entire vm (redux 1188)

Compiles on Mac and Windows, runs test suite on Mac at least.  I'm seeing some sampling crashes in debug builds but I doubt very much that this patch is the cause of that.