466891 - fetching imap flags twice

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

While looking at protocol logs, I've noticed us fetching 1:* flags twice for some folders. This is very bad for large folders. I'll try to figure out what's going on.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

If we're fetching all the flags without a CHANGEDSINCE clause, we need to mark the flag state as full, not partial. Then, we won't fall into this code:

        // if we did a CHANGEDSINCE fetch, do a sanity check on the msg counts
        // to see if some other client may have done an expunge.
        if (m_flagState->GetPartialUIDFetch())

and we'll avoid the double fetch.

Comment 2

[David :Bienvenu]

I'd like this for b1 - it's a regression and slows down loading large imap folders.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 350212 [details] [diff] [review]
proposed fix

>       if (!needFullFolderSync && !GetShowDeletedMessages() && UseCondStore())
>         PR_snprintf(fetchModifier, sizeof(fetchModifier), " (CHANGEDSINCE %llu)",
>                     mFolderLastModSeq);
>+      else
>+        m_flagState->SetPartialUIDFetch(PR_FALSE);
>+
> 
>       FetchMessage(idsToFetch, kFlags, fetchModifier);

nit: I don't think we need the extra blank line adding.

Comment 4

[David :Bienvenu]

fixed for tb 3.0 b1