Closed Bug 467251 Opened 16 years ago Closed 15 years ago

URL bar empty text should be right-aligned for RTL locales

Categories

(Firefox :: Address Bar, defect)

3.5 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Keywords: fixed1.9.1, rtl)

Attachments

(2 obsolete files)

Attached patch Patch (v1) (obsolete) — Splinter Review
The direction of URL bar is LTR even for RTL locales.  This causes the emptytext for URL bar (which should be translated and therefore RTL) appear on the left side of the URL bar, which is very odd.

This patch makes sure that this text appears right-aligned, as one would expect.
Attachment #350659 - Flags: review?(dao)
Comment on attachment 350659 [details] [diff] [review]
Patch (v1)

This belongs in browser/base/content/browser.css...

... but see also bug 416013, which I think is preferable.
Attachment #350659 - Flags: review?(dao) → review-
Component: Theme → Location Bar and Autocomplete
QA Contact: theme → location.bar
(In reply to comment #1)
> (From update of attachment 350659 [details] [diff] [review])
> This belongs in browser/base/content/browser.css...
> 
> ... but see also bug 416013, which I think is preferable.

Does that fix work even for cases where the direction of the text box is set to LTR using explicit CSS rules?  If I'm reading the patch there correctly, it checks the direction of the textbox, so it shouldn't work in this case.

If that bug doesn't fix this one, then I'll move my change to browser/base/content/browser.css...
Depends on: 416013
Attached patch Patch (v2) (obsolete) — Splinter Review
Only change browser/base/content/browser.css.
Attachment #350659 - Attachment is obsolete: true
Attachment #351249 - Flags: review?(dao)
Dao: ping?
The patch in bug 416013 should fix this.
This should be fixed.

Ehsan, can you please verify?
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Version: Trunk → 3.1 Branch
Attachment #351249 - Flags: review?(dao)
(In reply to comment #6)
> This should be fixed.
> 
> Ehsan, can you please verify?

Yep, it is indeed fixed.  Mozilla/5.0 (Windows; U; Windows NT 6.0; fa; rv:1.9.2a1pre) Gecko/20090114 Minefield/3.2a1pre
Status: RESOLVED → VERIFIED
Version: 3.1 Branch → Trunk
This bug is present on branch -- bug 416013 is waiting for approval.
Version: Trunk → 3.1 Branch
Attachment #351249 - Attachment is obsolete: true
Fixed on the branch by bug 416013.
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: