Closed Bug 467778 Opened 16 years ago Closed 16 years ago

dragover attribute is not always cleaned up correctly

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy][polish-interactive][polish-p3])

Attachments

(1 file, 2 obsolete files)

patch v1.1
1.99 KB, patch
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
when we drag over a folder child of a toolbar menu we null out overfolder to avoid closing the parent, but this way we will never unset "dragover" attribute.

This is a style issue only, we don't use that dragover for anything other (notice this "dragover" is not the same we set on menupopups)
Attachment #351187 - Flags: review?(dietrich)
Target Milestone: --- → Firefox 3.1
Attached patch patch (obsolete) — — Splinter Review 
while there a nit on a wrong comment
Attachment #351187 - Attachment is obsolete: true
Attachment #351190 - Flags: review?(dietrich)
Attachment #351187 - Flags: review?(dietrich)
Comment on attachment 351190 [details] [diff] [review]
patch

r=me. please provide STR for QA to verify.
Attachment #351190 - Flags: review?(dietrich) → review+
i tested this on XP where the blu hilight is quite visible.
1. create a new folder A on the bookmarks toolbar
2. create a new folder B inside folder A
3. create a new bookmark C on bookmarks toolbar
4. drag C inside B
5. close all menus, click on A, it should NOT be highlighted as if we were dragging on it
Attached patch patch v1.1 — — Splinter Review 
i wrongly removed var parent = popup.parentNode; in previous version, it should be there clearly since we check on it.
Attachment #351190 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/6b8fb1215fd7
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3.1 → Firefox 3.2a1
Comment on attachment 354820 [details] [diff] [review]
patch v1.1

asking approval for this polish bug, no risk.
Attachment #354820 - Flags: approval1.9.1?
Keywords: polish
Comment on attachment 354820 [details] [diff] [review]
patch v1.1

a191=beltzner
Attachment #354820 - Flags: approval1.9.1? → approval1.9.1+
Whiteboard: [polish-easy]
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre
Keywords: fixed1.9.1 → verified1.9.1
Status: RESOLVED → VERIFIED
This bug's priority relative to the set of other polish bugs is:
P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.
Whiteboard: [polish-easy] → [polish-easy][polish-interactive][polish-p3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: