Closed
Bug 468062
Opened 16 years ago
Closed 16 years ago
runtests.py should attempt to determine CPU architecture based on the avmshell
Categories
(Tamarin Graveyard :: Build Config, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brbaker, Assigned: brbaker)
Details
(Keywords: flashplayer)
Attachments
(1 file)
|
2.36 KB,
patch
|
dschaffe
:
review+
|
Details | Diff | Splinter Review |
Since windows64 and mac are able to run both 32bit and 64bit executables, relying on what python reports as the cpu type can be inaccurate since it will report as being 32bit. However if we used 'file' to acquire information about the executable then we could set the "cputype" more accurately. Need to fall back to current implementation if "file" is not available on the system.
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•16 years ago
|
||
Also update the ostype check to be a little more relaxed, don't need EXACT full string match (removes multiple checks for cygwin versions). Removed the win64 ostype, since it should just be 'win' with a cputype of 'x64' a.k.a. 'x64-win'
Attachment #351543 -
Flags: review?(dschaffe)
|
||
Updated•16 years ago
|
Attachment #351543 -
Flags: review?(dschaffe) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Pused redux 1199:6788c138004b
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•