46822 - Navigator home checkbox pref needs to be saved

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Alek Jeziorek]

-start browser
-Edit|Preferences 
-display is incorrect
Linux comm. 2000-07-28-08- ***M18***

Comment 1

[leger]

This is on Trunk.  Adding nsbeta3 keyword.  Alek, what is wrong about the 
display?

Comment 2

[Chris McAfee]

please expand on "display is incorrect"

Comment 3

[Alek Jeziorek]

the list of preference categories in the left part of the window is blank and it 
is missing the history and location bar history under the Navigator preferences

Comment 4

[Alek Jeziorek]

i get an XML error now when attempting to look at the navigator prefs:
XML Parsing Error: Unidentified entity
line number 81, column 23
value="&alwaysCheckWhenDropHome.label;"

using build 2000-08-08-08-M18

Comment 5

[johng]

nav triage team:
nsbeta3+, regression, dogfood keyword

Comment 6

[sairuh (rarely reading bugmail)]

clarifying summary. ben, you or...?

Comment 7

[leger]

Putting on [dogfood+] radar.  This is affecting daily testing!!

Comment 8

[sairuh (rarely reading bugmail)]

->all. confirmed on winnt, mac and linux.

Comment 9

[Blake Ross]

i think i know what the problem is (can you say 'element array'?)

Comment 10

[Blake Ross]

I'm pretty sure ben checked the change to navigator.xul in accidentally while 
fixing bug 45687 (see his checkin), but not the entity changes to 
navigator.dtd, which are causing these problems (alec fixed that).  So fast, 
simple fix is for someone to back out the navigator.xul changes for now (but I 
think i have the right fix, testing...)

Comment 11

[Peter "jag" Annema]

Attachment: [patch] now make it save this pref too

Comment 12

[Peter "jag" Annema]

Attached a patch which adds this pref to the array of elements to be saved to 
prefs.js.

Comment 13

[Blake Ross]

Thanks for attaching it jag. r=me (we just worked on it, but I was a bit far 
from home to be able to attach the patch myself)  So now if anyone could check 
this in...

Comment 14

[Alek Jeziorek]

cc:twalker

Comment 15

[selmer (gone)]

Ben, PDT thinks you should own checking this in.  Dogfood bugs are high 
priority.  Thanks,  Steve

Comment 16

[Blake Ross]

er.  This bug isn't dogfood+ or nsbeta3+ anymore. the navigator prefs display 
fine.  I was just gonna use this to checkin the simple fix, rather than filing 
a separate bug (I'll check it in tonight).

(It's also courteous to talk to the owner of a bug before reassigning it to 
someone else)

Comment 17

[Tracy Walker [:tracy]]

I'm uncertain that this is a bug.....There is another choice in the preferences 
window that brings up the history information in question.  2000-08-14-04-M18

Comment 18

[leger]

Putting on nsbeta3 nominee radar.

Comment 19

[Blake Ross]

Attachment: patch (something wrong with the other)

Comment 20

[Brendan Eich [:brendan]]

r=[e-mail], a=[e-mail].

/be

Comment 21

[Blake Ross]

Thanks, guys. Sorry to have kept buggin' ya. Fix checked in...

Comment 22

[Tracy Walker [:tracy]]

marking verified