46913 - URL gives sql error when loaded

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Luke]

select bugs.bug_id, product, version, rep_platform, op_sys, bug_status, 
resolution, priority, bug_severity, component, assigned_to, reporter, 
bug_file_loc, short_desc, target_milestone, qa_contact, status_whiteboard, 
date_format(creation_ts,'%Y-%m-%d %H:%i'), groupset, delta_ts, sum(votes.count) 
from bugs left join votes using(bug_id) where bugs.bug_id = 46872 and 
bugs.groupset & = bugs.groupset group by bugs.bug_id: You have an error in your 
SQL syntax near '= bugs.groupset group by bugs.bug_id' at line 10 at globals.pl 
line 134.

Comment 1

[Matthew Barnson]

I would resolve this "worksforme" -- tried the URL above and all was happiness.

Comment 2

[Luke]

Try it again, because it still gives the same sql error message for me.  

Comment 3

[Luke]

Further testing shows the bug has mysteriously disappeared, even for larger 
urls.  Marking WORKSFORME.

Comment 4

[Dave Miller [:justdave]]

It's still there.  Reopening.  The difference:  I wasn't logged in yet when I 
tried it.  If you're logged in, it works.  If you're not logged in, you get an 
error.

Apparently when you're not logged in, $::usergroupset is getting set to null, 
when it should be getting set to 0.  My guess is that something's goofed in 
quietly_check_login() in CGI.pl.

fyi, the new bugzilla server's giving funky error messages...

<?xml version="1.0" standalone="no"?>
<!DOCTYPE bugzilla SYSTEM "http://bugzilla.mozilla.org/bugzilla.dtd">
<bugzilla version="2.11" urlbase="http://bugzilla.mozilla.org/" maintainer=
"[e-mail]">
Content-type: text/html

<H1>Software error:</H1>
<CODE>
    select
      bugs.bug_id, product, version, rep_platform, op_sys, bug_status,
      resolution, priority, bug_severity, component, assigned_to, reporter,
      bug_file_loc, short_desc, target_milestone, qa_contact,
      status_whiteboard, date_format(creation_ts,'%Y-%m-%d %H:%i'),
      groupset, delta_ts, sum(votes.count)
    from bugs left join votes using(bug_id)
    where bugs.bug_id = 46872
    and bugs.groupset &  = bugs.groupset
    group by bugs.bug_id: You have an error in your SQL syntax near '= 
bugs.groupset
    group by bugs.bug_id' at line 10 at globals.pl line 134.
</CODE>
<P>
Please send mail to this site's webmaster for help.

Comment 5

[Dave Miller [:justdave]]

Found the bug.  Not in CGI.pl, but in Bug.pm.  It takes

Attaching a patch to fix it.

Comment 6

[Dave Miller [:justdave]]

Attachment: Patch to fix missing groupset in SQL

Comment 7

[Dave Miller [:justdave]]

Can't find any proof (queries are being weird on me?) but I think Dawn was in on 
creating Bug.pm.  If so, I'd like her review on this before it gets checked in.

Comment 8

[Chris Yeh]

reassigning to endico for her feedback, also flagging as possible 2.12

Comment 9

[Dave Miller [:justdave]]

Checked in patch.

Comment 10

[Tara Hernandez]

Sorry for the spam, but I needed to be able to query for all of these correctly.

Comment 11

[Jacob Steenhagen]

V.

Comment 12

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product