469499 - kill macbrowser ifdefs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Kaiser]

I just ran across some non-macbrowser-defined code in xpfe/components (which we probably should get rid of completely), and decided to see if we still have some of that code left anywhere. The places are scarce, and I really think we should get rid of those. If Camino moves on to being based on mozilla-central one time, they really should use a stock XULRunner as their base, if possible.

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove MOZ_MACBROWSER

Removes MOZ_MACBROWSER, since it's no longer defined:
http://mxr.mozilla.org/mozilla-central/search?string=MOZ_MACBROWSER

The now removed lines in mozSpellCheckerFactory.cpp were the last users of osxspell, so takes that out too:
http://mxr.mozilla.org/mozilla-central/search?string=OSXSpell

Comment 2

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=9709dc3e5f47

Comment 3

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/projects/cedar/rev/f4af0c314193

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f4af0c314193

Comment 5

[Nomis101]

Aaaaah, what please is the reason for completely removing OSXSpell? I use this constantly for my own builds and I love it. And a few bugs I've opened are based on OSXSpell.

Comment 6

[Ed Morley [:emorley]]

Removing MOZ_MACBROWSER caused it to become dead code per comment 1.

You presumably already had to patch your local build to enable it, so can't you just export the hg revert of this patch and add that to your mq?

Comment 7

[Nomis101]

(In reply to comment #6)
> You presumably already had to patch your local build to enable it, so can't
> you just export the hg revert of this patch and add that to your mq?
Yes, I had to revert Bug 422760 to enable it. But OK, I also will add this patch to my revert list. Thanks for the hint with mq!