Closed
Bug 469598
Opened 16 years ago
Closed 16 years ago
nsHTMLMediaElement::MetadataLoaded calls nsMediaDecoder::Seek(0)
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
1.01 KB,
patch
|
cajbir
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
It doesn't make sense to do this. The media will already be at the beginning, since we're just started loading it. Additionally, since this seek is executed after the user's script (for the loadedmetadata event), it can clobber the user's attempt to seek, since we could seek to the user's requested location, then immediately seek back to the media start.
Flags: blocking1.9.1?
|
Assignee | |
Comment 1•16 years ago
|
||
Remove the unnecessary seek, and the comment referring to the start attribute (which has been removed from the spec). Also removes some code from the Ogg decoder's seek which looks like a workaround for this problem. It's no longer necessary. It'd be good to get this fix in, since it can cause spurious test failures.
Attachment #352956 -
Flags: superreview?(roc)
Attachment #352956 -
Flags: review?(chris.double)
Attachment #352956 -
Flags: superreview?(roc) → superreview+
Flags: blocking1.9.1? → blocking1.9.1+
|
||
Updated•16 years ago
|
Attachment #352956 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
|
|
||
Comment 2•16 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/rev/3611062ed098
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs landing][baking for 1.9.1]
|
||
Comment 3•16 years ago
|
||
This needs to land on 1.9.1 before bug 462570 can land on 1.9.1.
Keywords: checkin-needed
|
|
||
Comment 4•16 years ago
|
||
Pushed to mozilla-1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ea80c6dfdd99
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs landing][baking for 1.9.1] → [needs landing]
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•