470203 - All add-on versions get sandboxed after new submission

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

All add-on versions get sandboxed after new submission. Maybe the latest public version has to be very new or it's related to the code removing older versions from the pending update queue.

Examples:
AutoPager https://addons.mozilla.org/en-US/firefox/addon/4925
VertTabbar https://addons.mozilla.org/en-US/firefox/addon/8045

Comment 1

[Wind Li]

For AutoPager, the last public version was released at November 9, 2008. The new version was uploaded at December 17, 2008.

Comment 2

[Fred Wenzel [:wenzel]]

Looking at r20493, that's the culprit here. Raising severity as it will gradually screw up a lot of add-ons if it stays like this :-/

Fligtar, are you around to fix that code?

Comment 3

[Fred Wenzel [:wenzel]]

By the way what *may* fix this is adding a "WHERE file.status = pending" to the SQL query. Currently you just mark *all* of the addon's files as sandboxed which is clearly not what the code intends to do.

Comment 4

[Justin Scott [:fligtar]]

Attachment: patch

Comment 5

[Fred Wenzel [:wenzel]]

Comment on attachment 353717 [details] [diff] [review]
patch

Yup, that looks like it should prevent the breakage.

Comment 6

[Justin Scott [:fligtar]]

r21087.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Wind, any chance you wouldn't mind verifying this as fixed using https://preview.addons.mozilla.org/en-US/developers?

Comment 8

[Wind Li]

(In reply to comment #7)
> Wind, any chance you wouldn't mind verifying this as fixed using
> https://preview.addons.mozilla.org/en-US/developers?

It works fine now.
I just upload a new version. Changed the max firefox version. Just as what I did in addons.mozilla.org.
All the public files still public.

Thanks for the quick fix.
Wind

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks for being patient and for helping with the verification, Wind!

Verified FIXED.

Comment 10

[:Gijs (he/him)]

Are we taking any action with respect to add-ons that already got hit. Looks, for example, like https://addons.mozilla.org/en-US/firefox/addons/versions/5447 got hit, too?

Comment 11

[Dave Garrett]

Crap. I just got hit by this. Didn't realize this wasn't pushed yet...
https://addons.mozilla.org/en-US/firefox/addons/versions/5791

Comment 12

[Dave Garrett]

Not to be a nag, but is there a reason why this fix hasn't been pushed yet? My public page was broken for a bit until Gijs was nice enough to review the new version for me. (no public versions for public add-on -> no download button and quite broken page) Would be nice to get this on production asap so as to not break things like this for anyone else.

And as to the other re-sandboxed versions, that needs another bug I guess? Is there a way to do it automatically or will someone have to go in and re-approve whole scores at once? (28 old versions in my case)

Comment 13

[Wind Li]

Not notice this hadn't been deployed. I just hit by this another time.   :'(

Comment 14

[Wil Clouser [:clouserw]]

I've filed bug 471200 to get this pushed and 471201 to fix the broken add-ons.

Comment 15

[Wind Li]

Thanks