470525 - "link" link for domain non-functional on "Top Crashers by Domain" report

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you load a "bydomain" report, the "link" link adjacent to the domain (as opposed to the "link" next to a particular page) is non-functional; it produces a link to the crash-stats page with the domain post-pended, e.g. for www.facebook.com, the "link" points to http://crash-stats.mozilla.com/topcrasher/bydomain/Firefox/www.facebook.com

Either the "link" link needs to be disabled for domains, or it needs to point to the domain.

On the other hand, generally having both the site/page *appear* to be a link (it's really just an additional expand/collapse widget like the +/-) and then having a second "link" link that is the real link to the site is a little confusing.  

I think ideally I'd prefer either a) the site/page link to the actual site and have no extra "link" link, or b) have the site/page not be a link at all (it could still be an additional expand/collapse widget as long as it didn't look like an actual link) and the "link" link be the link to the actual website.

(If we were to keep the "link" link, perhaps it should be renamed "visit page" or something.)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> On the other hand, generally having both the site/page *appear* to be a link
> (it's really just an additional expand/collapse widget like the +/-) and then
> having a second "link" link that is the real link to the site is a little
> confusing.  

This is going to get old for QA pretty quickly, I think.  When filing bug 470527, I kept trying to do Copy Link Location on the URL rather than on the "link", because it looks like a link and looks like the URL I want to copy....

I'm happy to spin the "what's a link and what isn't" part of this bug off into a new one, separate from the bad "link" links for domains, if you'd like.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 470563 from timeless about the "link" link.

Comment 4

[Austin King [:ozten]]

I read 470563, but am confused.

How about this.

- domain
  + url #
  - url #
    Signature - User Comment
Here the +/- widget, domain, and url links still do expand contract.
The # opens the url in a new window. domain does not have a '#'.
User Comment is a link to the crash report.

# is sometimes used as text for the "permalink" of a post in blogging. It is a stand-in until we get a graphic design for a "open this link in a new window" image.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Austin, while we try to find the correct linkification here we should have a look at bug 470561 in parallel. Without JS the page isn't accessible. So I would propose the following:

domain or +/- should be linked too. If JS is disabled the list of URL's should be collapsed/expanded. That means we have to reload the page with changed parameters.

# should be changed to e.g. 'open' or 'open link'

By linking the comments it's hard to follow one comment. Especially when it is wrapped. Could you also use a table oriented layout instead of dots? Probably with a different background for odd/even rows? In that way we can only highlight the currently hovered comment instead of all comments under the signature.

Just my 2c.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The setup that's active now (comment 4) is better.  

However, I have a philosophical dislike for sites making links open new windows, though; it's disruptive, and it shows that the site author presumes to know more about my workflow than I do.

I'd like to expand upon Henrik's comment about the "#", though; it's not going to be universally understood, and I'm not sure an image is the way to go, either, as it may be difficult to get an image that's universally understandable.  I'd prefer some text (being localizable, text is good for universal understanding), probably something like "open URL" or "view site".

I still think that having the "www.google.com" and "www.google.com/firefox" stuff look like regular links is confusing, though maybe changing the "#" for some descriptive text would help.

Comment 7

[Austin King [:ozten]]

Okay, links will not open in a new window automatically.

Comment 8

[Michael Morgan [:morgamic]]

Austin - is this fixed?

Comment 9

[Austin King [:ozten]]

Attachment: First attempt Fixes for url format and linking signatures

Wraps urls in a span so that we can have Copy in the link.
Adds "Expand" in front of domain or url which expands the list.
Changes # into "Open This URL" for offsite link.
Linkifies Crash signatures to the crash reports by signature listing page.

Comment 10

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 411419 [details] [diff] [review]
First attempt Fixes for url format and linking signatures

Looks good!  Ajax calls worked as directed...

Comment 11

[Austin King [:ozten]]

Committed r1441.