471577 - Add reviews to user profile pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Description

[Nick Nguyen [:osunick]]

This can be a simple list of addons the user has reviewed which are linked to the reviews they've written.  Ideally, it would be contain the entirety of the review content.

This is useful for two reasons- 1: it's a useful aspect of a user's profile and 2: it helps the editor team review new candidates for the editor team.

It's especially important because we're looking at ratcheting up the editor staff in January.  Thanks!

Comment 1

[Nick Nguyen [:osunick]]

Awesome mockup:

Add-ons by osunick
<addon listing>
Reviews by osunick
   <link to Delicious Bookmarks>
        Delicious is teh awesum
   <link to Firebug>
        Firebug is teh awesum

Styling can match the addon listing on user profile exactly.

Comment 2

[Fred Wenzel [:wenzel]]

This is a dupe of bug 377706, but because you made such an awesome mockup, I'll go ahead and dupe that bug against this.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: add user reviews to info page

This patch adds all of a user's reviews to their info page. Do you mind reviewing this, Laura?

Comment 5

[Fred Wenzel [:wenzel]]

Laura, do you have time to look at this before the code freeze or would you like me to give it to somebody else? Thanks :)

Comment 6

[Wil Clouser [:clouserw]]

Comment on attachment 357619 [details] [diff] [review]
add user reviews to info page

I think Laura is gone for the night so I looked at it.

It works for the most part, but I've got 2 comments:

1) If the user doesn't have a first/last name it just says "Review by ".  Since we're requiring one of first/last/nick name we should use the nick name if the others are blank.

2) The links to the add-ons are using whatever product is in the URL.  I remember making a special patch to fix this for the user's add-ons list so we should be consistent here.

Comment 7

[Fred Wenzel [:wenzel]]

Thanks, Wil. I'll push this out of 5.0.1 as well and fix the problems you mention.

Comment 8

[Fred Wenzel [:wenzel]]

Attachment: Adding reviews to user info page, take 2

This patch fixes the two problems you pointed out.

Comment 9

[Fred Wenzel [:wenzel]]

All right, thanks. Checked into r21881.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/user/235535.