Closed Bug 471584 Opened 16 years ago Closed 15 years ago

update Thunderbird 3 alpha users to beta

Categories

(Mozilla Messaging Graveyard :: Release Engineering, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wsmwk, Unassigned)

References

Details

Attachments

(4 files, 3 obsolete files)

update Thunderbird 3 alpha users to beta... a subject touched on in a previous meeting.  Not saying we must or should do it, but that it might be worth doing.

The value to users is, one would hope, improved stability.

From a dev/QA perspective it could 
a) be good release management experience in a low pressure, low impact setting
b) get more testers on beta 1 (or beta 2)
c) allow us to communicate with these users via the beta's start page, whereas right now we can't do this for alpha users

Perhaps two reasons why we might not want to do it
a) if people on the older releases are a useful control group 
b) what we gain is not worth the effort expended.
Component: Build Config → Release Engineering
Product: Thunderbird → Mozilla Messaging
QA Contact: build-config → release
Version: Trunk → other
I'm not against doing this if it's suitably little work, but I'm also not sure this generates a terribly high amount of value.

I'm also not sure whether the alpha binaries were spun in such a way as to allow this.  Standard8 would know, I bet...
I've built up the necessary Patcher configuration to produce the correct update snippets and patches to bring up our users to Beta 2.
Attachment #365905 - Flags: review?(bhearsum)
Comment on attachment 365905 [details] [diff] [review]
Patcher configuration for Thunderbird 3.0 series

><app>
>  <Thunderbird>

You need an <rc> section here, like this one:
http://mxr.mozilla.org/mozilla/source/tools/patcher-configs/moz191-branch-patcher2.cfg#19

We used to have 'rc' numbers instead of 'build' numbers (eg, 3.0b2-candidates/rc2) and that terminology has continued here. So the 'build' number should be used as the value for betatest/DisableCompleteJump

>
>  <current-update>
>    from = 3.0b1
>    to   = 3.0b2
>    channel = beta
>    testchannel = betatest
>    details = "http://www.mozillamessaging.com/en-US/thunderbird/3.0b2/releasenotes/"
>
>    force   freebl3.chk
>    force   softokn3.chk
>
>    <complete>
>      path = "thunderbird-3.0b2.%locale%.%platform%.complete.mar"

This worked for you when you generated MARs? I'm very surprised you don't need the nested dir format, shown here:
http://mxr.mozilla.org/mozilla/source/tools/patcher-configs/moz191-branch-patcher2.cfg#14

>      url = http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/3.0b2/update/%platform%/%locale%/thunderbird-3.0b2.complete.mar 
>      betatest-url = http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/3.0b2/update/%platform%/%locale%/thunderbird-3.0b2.complete.mar

Why aren't you using http://download.mozilla.org?

>      url = http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases/3.0b2/update/%platform%/%locale%/thunderbird-3.0b1-3.0b2.partial.mar 

You want to use the complete MAR here. This is why your partial snippets pointed to a partial mar. If you make this section identical to the <complete> one you'll get proper identical complete.txt and partial.txt files without having to manually copy them.

>    locales = en-US
>
>    <exceptions>
>      ja = win32, linux-i686
>      ja-JP-mac = mac
>    </exceptions>

You're not shipping ja/ja-JP-mac in this release, just remove this section to avoid confusion.


>  <3.0a2>

>    locales = en-US cs de fr ko lt nb-NO nn-NO pl pt-PT ru zh-CN
>
>    <exceptions>
>      ja = win32, linux-i686
>      ja-JP-mac = mac
>    </exceptions>

Same here.
 
>  <3.0a3>
>    locales = en-US be ca cs de es-AR es-ES fr fy-NL ga-IE hu id it ja lt nb-NO nl nn-NO pl pt-BR pt-PT ro ru si sk sv-SE zh-CN zh-TW

ja and ja-JP-mac are two entirely separate locales as far as build and release automation are concerned. You need to list them both here.


This is a good start, but not quite there yet. See above for detailed feedback.
Attachment #365905 - Flags: review?(bhearsum) → review-
(In reply to comment #3)
> (From update of attachment 365905 [details] [diff] [review])
> ><app>
> >  <Thunderbird>
> 
> You need an <rc> section here, like this one:
> http://mxr.mozilla.org/mozilla/source/tools/patcher-configs/moz191-branch-patcher2.cfg#19
> 
> We used to have 'rc' numbers instead of 'build' numbers (eg,
> 3.0b2-candidates/rc2) and that terminology has continued here. So the 'build'
> number should be used as the value for betatest/DisableCompleteJump

Can you explain a little more what this is for ?

> >
> >  <current-update>
> >    from = 3.0b1
> >    to   = 3.0b2
> >    channel = beta
> >    testchannel = betatest
> >    details = "http://www.mozillamessaging.com/en-US/thunderbird/3.0b2/releasenotes/"
> >
> >    force   freebl3.chk
> >    force   softokn3.chk
> >
> >    <complete>
> >      path = "thunderbird-3.0b2.%locale%.%platform%.complete.mar"
> 
> This worked for you when you generated MARs? I'm very surprised you don't need
> the nested dir format, shown here:
> http://mxr.mozilla.org/mozilla/source/tools/patcher-configs/moz191-branch-patcher2.cfg#14

Well, it did, but left each MAR side by side, and I figured I'd need to script something to copy them to their proper final destination. This looks much easier 

> This is a good start, but not quite there yet. See above for detailed feedback.

Yup, I've got most of it sorted out, thanks!
Includes most of the comments so far, except for the idea of configuring partials to be complete, since at least for Linux/Mac, we can do partials, only Win32 is busted.
Attachment #365905 - Attachment is obsolete: true
Attachment #365969 - Flags: review?(bhearsum)
Comment on attachment 365969 [details] [diff] [review]
 Patcher configuration for Thunderbird 3.0 series  v2

>    <complete>
>      path = "thunderbird/releases/3.0b2/update/%platform%/%locale%/thunderbird-3.0b2.complete.mar"

This is OK for this time, but in the future you'll want to use the thunderbird/nightly/3.0b3/update/..., because you'll likely be doing update generation before you've pushed the files to releases/.


>      url = http://download.mozilla.org/pub/mozilla.org/thunderbird/releases/3.0b2/update/%platform%/%locale%/thunderbird-3.0b2.complete.mar 

zuh? download.mozilla.org isn't a mirror, it's Bouncer. You need to use this style:
url   http://download.mozilla.org/?product=firefox-3.1b2-partial-3.1b1&os=%bouncer-platform%&lang=%locale%

Up to you whether you want to change the 'path' for the <complete> and <partial> section, but you definitely need to fix the bouncer links. r=bhearsum with that change.
Attachment #365969 - Flags: review?(bhearsum) → review-
All-inclusive configuration of what's on aus2.mozilla.org /betatest/ right now.
Attachment #366314 - Flags: review?(bhearsum)
Attachment #366314 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 366314 [details]
[checked in] Patcher configuration for Thunderbird 3.0 series v3

Looks good this time.
Attachment #366314 - Flags: review?(bhearsum) → review+
Running verify.sh on Linux right now with only a single warning:

WARN: non-binary files found in diff

diff -r source/thunderbird/defaults/pref/channel-prefs.js target/thunderbird/defaults/pref/channel-prefs.js
1c1
< //@line 2 "/builds/releases/3.0b1/2/comm-central/mail/app/profile/channel-prefs.js"
---
> //@line 2 "/builds/releases/3.0b2/2/comm-central/mail/app/profile/channel-prefs.js"
Attachment #366320 - Flags: review?(bhearsum)
Attachment #366320 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 366320 [details]
moz19-thunderbird-linux.cfg for verify.sh

You're not shipping ja-JP-mac on linux, please remove it from the appropriate lines.

r=bhearsum with that change
Attachment #366320 - Flags: review?(bhearsum)
Comment on attachment 366314 [details]
[checked in] Patcher configuration for Thunderbird 3.0 series v3

RCS file: /cvsroot/mozilla/tools/patcher-configs/moz19-thunderbird-branch-patcher2.cfg,v
done
Checking in moz19-thunderbird-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz19-thunderbird-branch-patcher2.cfg,v  <--  moz19-thunderbird-branch-patcher2.cfg
initial revision: 1.1
done
Attachment #366314 - Attachment filename: moz19-thunderbird-branch-patcher2.cfg → [checked in] moz19-thunderbird-branch-patcher2.cfg
Attachment #366314 - Attachment description: Patcher configuration for Thunderbird 3.0 series v3 → [checked in] Patcher configuration for Thunderbird 3.0 series v3
Attachment #366314 - Attachment filename: [checked in] moz19-thunderbird-branch-patcher2.cfg → moz19-thunderbird-branch-patcher2.cfg
Attachment #366824 - Flags: review?(bhearsum) → review+
Attachment #366825 - Flags: review?(bhearsum) → review+
Ran verify.sh -c on os x with only the same problems as on linux in comment #9
Comment on attachment 366320 [details]
moz19-thunderbird-linux.cfg for verify.sh

For completeness, better ask for review on this one too
Attachment #366320 - Flags: review?(bhearsum)
Comment on attachment 366320 [details]
moz19-thunderbird-linux.cfg for verify.sh

This one still has ja-JP-mac in it. r=bhearsum with that removed.
Attachment #366320 - Flags: review?(bhearsum) → review-
Forgot to update the attachment with the latest one that didn't include ja-JP-mac
Attachment #366320 - Attachment is obsolete: true
Blocks: 482962
Attachment #365969 - Attachment is obsolete: true
Comment on attachment 366824 [details] [diff] [review]
[checked in] moz19-thunderbird-mac.cfg for verify.sh

comparing with http://hg.mozilla.org/build/tools                                                                                                                                              
searching for changes                                                                                                                                                                         
changeset:   242:27453eb43283
tag:         tip
user:        Philippe M. Chiasson <gozer@mozillamessaging.com>
date:        Thu Mar 12 10:55:18 2009 -0400
summary:     Bug 471584. updates/verify.sh configs for Thunderbird 3.0 family. r=bhearsum
Attachment #366824 - Attachment description: moz19-thunderbird-mac.cfg for verify.sh → [checked in] moz19-thunderbird-mac.cfg for verify.sh
Attachment #366825 - Attachment description: moz19-thunderbird-win32.cfg for verify.sh → [checked in] moz19-thunderbird-win32.cfg for verify.sh
Attachment #367042 - Attachment description: moz19-thunderbird-linux.cfg for verify.sh v2 → [checked in] moz19-thunderbird-linux.cfg for verify.sh v2
Suggested date/time to start serving updates to our Alpha/Beta users:

Thursday, March 19th, noon PDT.
Update snippets pushed live, updates should start to be offered now.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: