47166 - Open/Save Attachment dialog doesn't allow keyboard shortcuts

Status: RESOLVED WORKSFORME

(Core Graveyard :: File Handling, defect, P3)

Description

[Kathleen :Brade]

I select an attachment to save locally and get a dialog prompting me to choose 
between opening it and saving it to disk.  I choose Save it to disk and then 
press return/enter keys.  Nothing happens.  Then I press escape key.  Nothing 
happens.  I expect these shortcut keys to work in all dialogs (esp. if the return 
icon (left-pointing arrow) is present).

Comment 1

[Kathleen :Brade]

we should fix this for rtm/nsbeta3

Comment 2

[rhp (gone)]

This is not mail/news. This belongs to whoever owns nsIFileSpec and the 
ChooseOutputFile() method off of that.

- rhp

Comment 3

[rhp (gone)]

finding right owner...

Comment 4

[rhp (gone)]

nsIFileSpec issue.

Comment 5

[Ray Whitmer]

Wrong.

nsIFileSpec is a depricated API, which does not contain the method 
ChooseOutputFile, which is defined, not in any IDL, but in 
widget/src/xpwidgets/nsFileSpecWithUIImpl.cpp.

Comment 6

[Ray Whitmer]

Reassigning to XP Toolkit/Widgets

Comment 7

[Kevin McCluskey (gone)]

I think this one was assigned to me by mistake. 
Peter: do you know who owns nsFileSpecWithUIImpl?

Comment 8

[Peter Trudelle]

Is this just a problem with attachments, or are other file open/save dialogs
affected?  Is this really Mac-specific?
cc Law

Comment 9

[Kathleen :Brade]

sorry; I'm about to go on my sabbatical.  I don't know if this is platform-
specific or not.

My complaint isn't about the MacOS save/open dialogs, it's about the (mime?) 
dialog I get before I am prompted to save (you click the radio buttons to either 
open or save the file...)

cc Charley since he also has a bug like this (though in a Composer dialog).

Comment 10

[leger]

Updating QA Contact.

Comment 11

[Peter Trudelle]

This works in other dialogs, so should be an apps issue, not toolkit. Does
anyone know who owns that dialog?   reassigning to selmer, since it is
mail-specific. 

Comment 12

[scottputterman]

Is this a dup of 34051?

Comment 13

[John Morrison]

No, this can't be bug 34051, as that is about FileSpec interfaces. This is
about a modal dialog, specifically 
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/
openSaveAttachment.xul

I see that this pulls in dialogOverlay.xul, which should give it keybindings
for the OK and Cancel buttons, and a binding for ESC, but this doesn't seem
to be working. I also tried another dialog (askSendFormat.xul?) which also
doesn't work for these keyboard shortcuts. 

This needs a further look to figure out why this is failing (apps not set up
correctly, or some binding/focus issue). [tested on win2k].

Comment 14

[selmer (gone)]

nsbeta3-, doesn't seem to meet P1 or P2 criteria.

Comment 15

[selmer (gone)]

Accepting to get out of bugzilla nag mail.

Comment 16

[Marcia Knous [:marcia]]

nominating for dogfood (from sdagley's list of bugs that are good candidates for 
our next release) 

Comment 17

[sairuh (rarely reading bugmail)]

over to file handling.

Comment 18

[Simon Paquet [:sipaq]]

This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".

Comment 19

[Kathleen :Brade]

resolve this as worksforme; The shortcuts now work in mozilla 1.4/netscape 7.1
on osx.