471903 - pref urlbar.autocomplete.enabled is no longer implemented

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

it's set during IE migration:

http://mxr.mozilla.org/mozilla-central/search?string=urlbar.autocomplete.enabled

and defined, but not used in Places:

http://mxr.mozilla.org/mozilla-central/ident?i=PREF_AUTOCOMPLETE_ENABLED


if it's a valid IE setting for toggling autocomplete and is turned off, we should set browser.urlbar.search.sources = 0.

Comment 1

[Ed Lee :Mardak]

Seems to be used in suite.... ? somehow?

http://mxr.mozilla.org/comm-central/search?string=autocomplete.enabled&find=suite%2F

Comment 2

[Ed Lee :Mardak]

Seamonkey is expecting autocomplete.enabled, and search.sources should probably go away per bug 472943.

We can fix both by changing search.sources=0 into autocomplete.enabled and then fix firefox ui to use default.behavior instead of search.sources for the dropdown.

I'll whip something up for trunk and probably request blocking 191 or something.

Comment 3

[Ed Lee :Mardak]

Attachment: v1

Hook up the dropdown to two prefs and always update .enabled. Remove search.sources and switch turning off ability to check .enabled.

Comment 4

[Dietrich Ayala (:dietrich)]

setting p1, as mardak says it breaks AC for seamonkey

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 357376 [details] [diff] [review]
v1

r=me. the pref is less easy to understand, but since we have UI for the common cases, i'm not so worried about it. the lack of confusion over two prefs is definite win.

Comment 6

[Ed Lee :Mardak]

Moved pref to "toolkit.js" (all.js) from firefox.js.

http://hg.mozilla.org/mozilla-central/rev/68391d886801

Comment 7

[Ed Lee :Mardak]

b191? as seamonkey has broken functionality with this regression.

Comment 8

[Ed Lee :Mardak]

Comment on attachment 357376 [details] [diff] [review]
v1

a191? to fix seamonkey. Has tests and cleans up prefs.

Comment 9

[Ed Lee :Mardak]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9443320abbb2

Comment 10

[Ed Lee :Mardak]

dev-doc-needed: Just incase the pref was lost in the docs somewhere along the way because it wasn't implemented earlier.

Comment 11

[Eric Shepherd [:sheppy]]

We don't really have documentation for these sorts of preferences at all right now.  There's a separate bug already for adding documentation to cover prefs, so I'm removing teh doc needed tag here.