472052 - permissions needs to let go during shutdown-cleanse

Status: RESOLVED WONTFIX

(Core :: Networking: Cookies, defect)

Description

[timeless]

Attachment: release db handle for cleanse

in bug 426200 comment 6, dwitte noted that permissions had the same problem as cookies.... i know it's a bit late, but here's the patch.

Comment 1

[[e-mail]]

Comment on attachment 355310 [details] [diff] [review]
release db handle for cleanse

looks good, however i remember we also ended up having debug spew in cookies by not finalizing sqlite statements before closing the db, which we fixed by adding a CloseDB() method that does things in the right order: http://hg.mozilla.org/mozilla-central/rev/fd7c994ec1e9

can you rejig this patch to do it that way? r=me with that, and no need for sr on something this simple. (please do post the patch though, so i can take a look)

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

I believe this may be INVALID because we don't do shutdown-cleanse. Instead, I think jdm's work already ensures that we clear cookies at the correct time, right?

> +NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was
> +intended to clear profile data. This is no longer sent and observer code should
> +remove support for it.

Comment 3

[Josh Matthews [:jdm]]

Sanitization is handled by http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js, which deals with clearing cookies and site permissions.