Closed Bug 472120 Opened 15 years ago Closed 15 years ago

nsIPrivateDOMEvent outparamdel didn't change IID

Categories

(Core :: DOM: Events, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: taras.mozilla)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

See bug 456099 and the "Changed declaration of nsIPrivateDOMEvent without changing IID" thread in m.d.t.dom.

We need to rev this IID, since we changed this interface from 1.9 to 1.9.1...
Flags: blocking1.9.1?
Blocks: 456099
Ideally, outparamdel would automatically rev the iid of any interfaces it changes.
Attached patch increment iid (obsolete) — Splinter Review
Attachment #355425 - Flags: review?(bzbarsky)
(In reply to comment #1)
> Ideally, outparamdel would automatically rev the iid of any interfaces it
> changes.

The macrology used to set the IID makes that a bit of a tricky task to find the part of the code where the IID digits are defined which makes it hard to autorefactor. I'll think about it some more.
I bet a regex could get really close, though.
Comment on attachment 355425 [details] [diff] [review]
increment iid

Please use an actual UUID generator (worst case, |/msg firebot uuid| on irc) to do this?  And fix the comment too?
Attachment #355425 - Flags: review?(bzbarsky) → review-
Attachment #355425 - Attachment is obsolete: true
Attachment #355434 - Flags: review?(bzbarsky)
Comment on attachment 355434 [details] [diff] [review]
fix IID (using generated one)

Looks good.
Attachment #355434 - Flags: superreview+
Attachment #355434 - Flags: review?(bzbarsky)
Attachment #355434 - Flags: review+
Keywords: checkin-needed
pushed http://hg.mozilla.org/mozilla-central/rev/d3fd61af3225
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
No harm done, since clearly this needs to land on 1.9.1 either way, but technically you should have gotten approval first (or waited until it was blocker). You also need to use the fixed1.9.1 keyword to mark bugs as fixed there.
Keywords: fixed1.9.1
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: